Page MenuHomePhabricator
Differential D16656

[ecash-lib] Replace legacy ChronikClientNode references with ChronikClient
ClosedPublic
Actions

Authored by bytesofman on Aug 15 2024, 23:23.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Commits
rABC656d823277b2: [ecash-lib] Replace legacy ChronikClientNode references with ChronikClient
Summary

as in title

Test Plan

npm test, CI test, grep -r ChronikClientNode . and no output

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bytesofman created this revision.Aug 15 2024, 23:23
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 15 2024, 23:23
bytesofman published this revision for review.Aug 15 2024, 23:24
Harbormaster completed remote builds in B30004: Diff 49245.Aug 15 2024, 23:46
emack requested changes to this revision.Aug 16 2024, 01:30
emack added a subscriber: emack.

Are these the equivalent of node_module files for react apps and can be ignored?

image.png (89×1 px, 28 KB)

This revision now requires changes to proceed.Aug 16 2024, 01:30
bytesofman added a comment.Aug 16 2024, 17:31
In D16656#377331, @emack wrote:

Are these the equivalent of node_module files for react apps and can be ignored?

image.png (89×1 px, 28 KB)

dist is what is built from typescript

so -- if you npm run build on this branch, then you should no longer see these

would expect to see them if you have built ecash-lib before (which would be expected, as it has to be done to run Cashtab locally).

bytesofman requested review of this revision.Aug 16 2024, 17:32
emack accepted this revision.Aug 17 2024, 05:07
This revision is now accepted and ready to land.Aug 17 2024, 05:07
Closed by commit rABC656d823277b2: [ecash-lib] Replace legacy ChronikClientNode references with ChronikClient (authored by bytesofman). · Explain WhyAug 18 2024, 15:51
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABC656d823277b2: [ecash-lib] Replace legacy ChronikClientNode references with ChronikClient.

Revision Contents
Changeset List

PathSize
modules/
ecash-lib/
src/
test/
12 lines
tests/
4 lines
4 lines
4 lines

Diff 49280

View Options

modules/ecash-lib/src/test/testRunner.ts

Loading...
View Options

modules/ecash-lib/tests/alp.test.ts

Loading...
View Options

modules/ecash-lib/tests/slp.test.ts

Loading...
View Options

modules/ecash-lib/tests/txBuilder.test.ts

Loading...