Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABCfa1fa0ba9184: [e.cash] Add button and bip70 label to wallets page

Summary

Slightly changed the copy at the beginning and added a button to our wallet guide. Also added the BIP-70 label to wallets that support it.

Test Plan

Visit e.cash/wallets and check copy, scroll down and check labels. Click the "Wallet Guide" button to see if it leads to the blog post.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

bip70label

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 30079
Build 59691: Build Diff
Build 59690: arc lint + arc unit

Event Timeline

Kronkmeister created this revision.Aug 23 2024, 21:05

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 23 2024, 21:05

Harbormaster completed remote builds in B30079: Diff 49342.Aug 23 2024, 21:05

changed Bip to BiP. (fixing issue with linters)

Harbormaster completed remote builds in B30080: Diff 49343.Aug 23 2024, 21:08

changed BiP to BIP.

Harbormaster completed remote builds in B30081: Diff 49344.Aug 23 2024, 21:12

Kronkmeister published this revision for review.Aug 24 2024, 00:14

Kronkmeister edited the summary of this revision. (Show Details)

Kronkmeister edited the test plan for this revision. (Show Details)

PiRK added a subscriber: PiRK.Aug 26 2024, 06:41

PiRK added inline comments.

web/e.cash/pages/wallets.js
79 ↗	(On Diff #49344)	double check with a native english speaker, but I think "checkout" does not work here

Fix typo: Changing "checkout" to "check out".

Harbormaster completed remote builds in B30089: Diff 49359.Aug 26 2024, 19:44

@bot preview-e.cash

web/e.cash/data/wallets.js
27 ↗	(On Diff #49359)	not really in-scope for this diff but imo BIP70 could use a rebrand, esp for user-facing material only devs talk about features as "bipxx" ... and even there I have to google it a lot of the time....obv no one remembers bip1 through bip69 off the top of their heads, we can't expect casual users to know this. Verified invoicing? Real time invoicing? something to think about
web/e.cash/pages/wallets.js
77–80 ↗	(On Diff #49359)

Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://51.83.66.92:41952 for the next 60 minutes.

bytesofman requested changes to this revision.Aug 26 2024, 23:21

This revision now requires changes to proceed.Aug 26 2024, 23:21

The user-level idea is to make them see which of those wallets support BitPay invoices. It is officially titled as "Payment Protocol", we could also add "Bitpay support" in that sense.

However, Bitpay does not even support eCash yet. It would be a useful data point for power users and devs, but there's no pressing reason to add any label now. I am happy to leave that label out until we find a good solution. But I will revise this diff to go on with adding the button to the wallet guide.

Removing bip-70 label change. Will be added later with a user-facing label like "BitPay support"
or "Payment Protocol". Retaining the wallet guide button at the top of the page.

Harbormaster completed remote builds in B30090: Diff 49360.Aug 26 2024, 23:47

bytesofman requested changes to this revision.Aug 27 2024, 16:43

bytesofman added inline comments.

web/e.cash/pages/wallets.js
77–80 ↗	(On Diff #49359)	I think it's ok to include BIP70 support as a placeholder label for now, up to you. Just looking for some minor text changes here.