Page MenuHomePhabricator

[explorer] Remove extra spaces around 's'
ClosedPublic

Authored by johnkuney on Aug 27 2024, 03:48.

Details

Reviewers
PiRK
tobias_ruck
Group Reviewers
Restricted Project
Commits
rABCa3125926c643: [explorer] Remove extra spaces around 's'
Summary

on a transaciton page, in the block row under general details, the 's' in confirmations has a space either side
This came from the line break from the new formatting

Test Plan

preview the site and check the space is no longer there

Diff Detail

Repository
rABC Bitcoin ABC
Branch
explorer-confirmations
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 30104
Build 59741: Build Diff
Build 59740: arc lint + arc unit

Event Timeline

PiRK added inline comments.
web/explorer/explorer-server/templates/pages/transaction.html
134 ↗(On Diff #49362)

What does the dash do? Is there a link to some doc about this somewhere?
It seems like it is freaking out the new linter (see extra indentation below)

This revision is now accepted and ready to land.Aug 27 2024, 15:47

actually this is still causing the space after the 's' looks like

Here is some not too helpful doc....https://djc.github.io/askama/configuration.html#whitespace-control

Im having trouble getting it to work and not add a bunch of new formatting to the rest of the page...

yeah this is the only way I can get it to work, but it tabs everything below it over

tobias_ruck added a subscriber: tobias_ruck.
tobias_ruck added inline comments.
web/explorer/explorer-server/templates/pages/transaction.html
134

you can just repeat "confirmation" and not use {%-, which seems to confuse djlint

This revision now requires changes to proceed.Aug 27 2024, 21:21

fix spacing issue and avoid extra formatting

good call thanks, had to add the closing ) in each one as well

Works for me 👍🏻

Maybe in the future we can fix the formatter and simplify this again

This revision is now accepted and ready to land.Aug 28 2024, 19:24
This revision was automatically updated to reflect the committed changes.