tests: fix formatting of itemid in p2p_inv_download
ClosedPublic
Actions

Authored by PiRK on Aug 28 2024, 09:11.

Details

Reviewers

roqqit

Group Reviewers

Restricted Project

Commits

rABCc58302608fc6: tests: fix formatting of itemid in p2p_inv_download

Summary

This new test added in D16668 caused intermittent failures when the itemid hex representation started with a 0

AssertionError: [node 0] Expected messages "['received getdata (1 invsz)', 'received getdata for: 0x1f000002 8cbfe7dca09271f2d028790ae71770b1b4a6263e88fa0bf9e29ab118be195ea']" does not partially match log:

    - 2024-08-27T20:02:23.029782Z [../../src/net_processing.cpp:5330] [ProcessMessage] received getdata for: 0x1f000002 08cbfe7dca09271f2d028790ae71770b1b4a6263e88fa0bf9e29ab118be195ea peer=1

Use the uint256_hex helper function to properly format the inv id.

Test Plan

ninja check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Branch

fix_p2p_inv_download

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 30114
Build 59761: Build Diff	build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 59760: arc lint + arc unit