[electrum] remove misleading LIBSECP_COMMIT var
ClosedPublic
Actions

Authored by PiRK on Sep 6 2024, 07:50.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC241cae514ecc: [electrum] remove misleading LIBSECP_COMMIT var

Summary

We build libsecp from the latest master branch on the github repo. This variable has been unused for a very long time and is misleading.

Test Plan

grep -r "LIBSECP_COMMIT" .

Diff Detail

Repository

rABC Bitcoin ABC

Branch

electrum_pyinstaller_bump

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 30205
Build 59937: Build Diff	electrum-tests
Build 59936: arc lint + arc unit

Event Timeline

PiRK created this revision.Sep 6 2024, 07:50

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 6 2024, 07:50

PiRK requested review of this revision.Sep 6 2024, 07:50

Harbormaster completed remote builds in B30205: Diff 49526.Sep 6 2024, 07:52

Fabien accepted this revision.Sep 6 2024, 08:03

This revision is now accepted and ready to land.Sep 6 2024, 08:03

Closed by commit rABC241cae514ecc: [electrum] remove misleading LIBSECP_COMMIT var (authored by PiRK). · Explain WhySep 6 2024, 08:19

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC241cae514ecc: [electrum] remove misleading LIBSECP_COMMIT var.

Revision Contents
Changeset List

Path

Size

electrum/

contrib/

osx/

make_osx

1 line

Diff 49526

View Options

electrum/contrib/osx/make_osx

[electrum] remove misleading LIBSECP_COMMIT varClosedPublicActions