Page MenuHomePhabricator
Differential D16742

[token-server] Tighten rate limits
ClosedPublic
Actions

Authored by bytesofman on Sep 10 2024, 21:14.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Commits
rABC0fa945d62703: [token-server] Tighten rate limits
Summary

Still seeing some dedicated eCash scripters out there. Will probably need to get fail2ban going soon, but we will also need to do this.

Add rate limit object to config. Make it a param of startExpressServer, so that we can have different rate limits for the prod app and the unit tests. Include high rate limits for the tests so we do not rate limit ourselves.

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
token-server-tighter-ratelimits
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 30235
Build 59997: Build Difftoken-server-tests
Build 59996: arc lint + arc unit

Event Timeline

bytesofman created this revision.Sep 10 2024, 21:14
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 10 2024, 21:14
bytesofman updated this revision to Diff 49567.Sep 10 2024, 21:16

better unit test rate limit settings

Harbormaster completed remote builds in B30234: Diff 49566.Sep 10 2024, 21:16
bytesofman published this revision for review.Sep 10 2024, 21:17
Harbormaster completed remote builds in B30235: Diff 49567.Sep 10 2024, 21:18
bytesofman added inline comments.Sep 10 2024, 21:19
apps/token-server/config.ts
55

window from 60 min to 120 min

56

limit from 10 to 3

emack accepted this revision.Sep 11 2024, 05:23
This revision is now accepted and ready to land.Sep 11 2024, 05:23
Closed by commit rABC0fa945d62703: [token-server] Tighten rate limits (authored by bytesofman). · Explain WhySep 11 2024, 05:49
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABC0fa945d62703: [token-server] Tighten rate limits.

Revision Contents
Changeset List

PathSize
apps/
token-server/
17 lines
2 lines
src/
13 lines
test/
9 lines

Diff 49567

View Options

apps/token-server/config.ts

Loading...
View Options

apps/token-server/index.ts

Loading...
View Options

apps/token-server/src/routes.ts

Loading...
View Options

apps/token-server/test/routes.test.ts

Loading...