Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC74c6e91dccac: [ecash-agora] Add `AgoraPartial.script` to build the Script for partial SLP…

Summary

Add a function building the SLP version of the script for offers that can be partially accepted.

This doesn't add a way of spending them yet, and tests are more to "pin" the script code (which is important, so future refactors don't change the script code), than to actually test if they work as intended. All of which will be added in a future diff.

Depends on D16735.

Test Plan

npm run test

Diff Detail

Repository

rABC Bitcoin ABC

Branch

ecash-agora-partial-script-slp

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 30305
Build 60137: Build Diff	ecash-agora-integration-tests · ecash-agora-tests
Build 60136: arc lint + arc unit

Event Timeline

tobias_ruck created this revision.Sep 10 2024, 22:59

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 10 2024, 22:59

Harbormaster completed remote builds in B30237: Diff 49571.Sep 10 2024, 23:06

add ecash-agora-tests to build

Harbormaster completed remote builds in B30238: Diff 49572.Sep 10 2024, 23:17

rebase

Harbormaster completed remote builds in B30240: Diff 49574.Sep 10 2024, 23:22

@bot ecash-agora-tests

teamcity awarded a token.Sep 10 2024, 23:37

tobias_ruck published this revision for review.Sep 11 2024, 07:33

tobias_ruck added a child revision: D16745: [ecash-agora] Partial Agora offers: Add SLP support to plugin, `Agora` and `AgoraOffer`.Sep 11 2024, 13:31

tobias_ruck retitled this revision from [ecash-agora] Add `AgoraPartial.script` to build the Script for partial offers to [ecash-agora] Add `AgoraPartial.script` to build the Script for partial SLP offers.Sep 11 2024, 13:51

rebase on master

Harbormaster completed remote builds in B30305: Diff 49656.Sep 16 2024, 19:30

tobias_ruck removed a parent revision: D16735: [ecash-agora] Partial Agora offers: Add approximation logic.Sep 16 2024, 19:39

bytesofman added inline comments.Sep 16 2024, 21:51

modules/ecash-agora/src/partial.ts
540	what is `intros.` ?
569	this was worked out separately right? as in, some kind of script debugger? not sure what value there is in manually reviewing it here except for, say, typos, or if there is some condition missed in testing. everything in `fromOps` is ... effectively generated code? Is it practical/possible for someone to engineer complicated scripts like this just using all of these `OP_xxx` variables? how did you write this?
570	some comments start with `// #`, others with just `//` -- is there some key distinction or is this a coincidence?

tobias_ruck added inline comments.Sep 17 2024, 07:25

modules/ecash-agora/src/partial.ts
540	In the case of SLP, it's the SLP SEND OP_RETURN script with one 0 token output already there (the others will be added in the script, therefore "intro"). In the case of ALP, it's the ALP SEND pushdata, but without the number of amounts (the amounts will be added in the script). Maybe there's a better name than intro, but since it's a fixed bytestring and it's in the beginning, intro could make sense.
569	This script was hand-written, but using my (very hard-to-use) Iguana debugger (written in TS and Rust) so I always see what's on the stack etc.. I'm not sure how we should go about reviewing this; you can try to follow what's going on in the Script, but it's going to be difficult. We can also hop on a call and I explain it, we can record it and add it to the diff for posterity. The GNC approved a very simplified version of Iguana already, and I plan to extend it in the future, and maybe have a proper compiler in the future. But I don't think this diff should be blocked by that.
570	Well I have this convention here that `// #` are plain English comments and `//` are more formal, as if there was a language for these opcodes. Maybe Tendo and I can build something more friendly here.