reference to #10710
Details
Details
- Reviewers
deadalnix qshuai - Group Reviewers
Restricted Owners Package (Owns No Changed Paths) Restricted Project - Commits
- rSTAGING26a650b5f5aa: fix confusing parameter information
rABC26a650b5f5aa: fix confusing parameter information
// Add a bitcoin-abc node firstly
bitcoin-cli addnode 67.82.89.67 add
// Commands and returned results as following:
bitcoin-cli getaddednodeinfo true error code: -24 error message: Error: Node has not been added.
bitcoin-cli getaddednodeinfo true 67.82.89.67 error code: -1 error message: getaddednodeinfo ( "node" )
// the correct usage:
bitcoin-cli getaddednodeinfo
bitcoin-cli getaddednodeinfo 67.82.89.67
So getaddednodeinfo only have one optional argument<node>.
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- arcpatch-D1447
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 3328 Build 4739: Bitcoin ABC Buildbot (legacy) Build 4738: arc lint + arc unit
Event Timeline
Comment Actions
Please explain what was confusing in the existing example.
Also please fill out a test plan that someone can follow.
Comment Actions
@deadalnix Have to admit, I am a newer for using arc to contribute. With the same change, I built and ran all unit testings pass. But I can not fix this built error with my several tries.
Explain:
getaddednodeinfo rpc command requires only one parameter<ip optional>. But the help information declares that it works with two parameter<additional bool parameter>. The bitcoin core developers has fix it, view
bitcoin-cli addnode 67.82.89.67 add bitcoin-cli getaddednodeinfo true error code: -24 error message: Error: Node has not been added. bitcoin-cli getaddednodeinfo true 67.82.89.67 error code: -1 error message: getaddednodeinfo ( "node" ) // the correct usage: bitcoin-cli getaddednodeinfo bitcoin-cli getaddednodeinfo 67.82.89.67
Comment Actions
I was a little puzzled until I realized that the help text does not specify the param at all. Looking at the implementation, it appears that the bool param is not supported.
I looked at the link you provided and it looks like you're effectively backporting part of this PR: https://github.com/bitcoin/bitcoin/pull/10710
In that case, I think the code block in your latest comment would qualify as the test plan. :)
Things that you need to do before we accept this diff:
- Update the Test Plan with the code block you provided showing the tested commands and their outputs.
- Update the diff summary to reference partial-backport of PR 10710.