Differential D16811

[iguana] Fix several build issues
ClosedPublic
Actions

Authored by Fabien on Sep 25 2024, 08:43.

Details

Reviewers

tobias_ruck

Group Reviewers

Restricted Project

Commits

rABC9697427b4805: [iguana] Fix several build issues

Summary

This fixes a few build issues from iguana that have been caught by CI:

Move the directory to src/ where it belongs, fixing the include paths and sanitizer linkage
Fix the description because it's not bitcoin-tx
Remove the redundant C++ parameters so it inherits from the high level project
Exclude from the default install so we don't ship the binary that currently is an empty shell
Work around a cmake/linker combo bug
Build the iguana target first before running the tests on CI. This is not a behavior change because the dependencies are set properly, but it will help stop the build early if it fails so it makes parsing CI easier

Test Plan

ninja all check-iguana install

Run the sanitizers build and the windows cross build.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Sep 25 2024, 08:43

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 25 2024, 08:43

Fabien requested review of this revision.Sep 25 2024, 08:43

Fabien edited the summary of this revision. (Show Details)Sep 25 2024, 08:45

Undo test util linkage

@bot build-ubsan build-asan build-tsan build-win64

teamcity awarded a token.Sep 25 2024, 08:46

Fabien edited the summary of this revision. (Show Details)Sep 25 2024, 08:54

Harbormaster completed remote builds in B30412: Diff 49819.Sep 25 2024, 09:02

Harbormaster completed remote builds in B30411: Diff 49818.Sep 25 2024, 09:04

Build Bitcoin ABC Diffs / Diff Testing (build-win64) failed.

Tail of the build log:

Warning: .drectve `-exclude-symbols:"anon.cf0c30d79d0129f546b5107c702e7200.0.llvm.7448814864795828593" ' unrecognized
Warning: .drectve `-exclude-symbols:"anon.cf0c30d79d0129f546b5107c702e7200.1.llvm.7448814864795828593" ' unrecognized
Warning: corrupt .drectve at end of def file
Warning: .drectve `-exclude-symbols:"_ZN102_$LT$core..iter..adapters..map..Map$LT$I$C$F$GT$$u20$as$u20$core..iter..traits..iterator..Iterator$GT$4fold17h3fc9caf37833e137E" ' unrecognized
Warning: corrupt .drectve at end of def file
Warning: .drectve `-exclude-symbols:"_ZN11tungstenite9handshake6client24ClientHandshake$LT$S$GT$5start17hcdc1623cef905054E" ' unrecognized
Warning: corrupt .drectve at end of def file
Warning: .drectve `-exclude-symbols:_ZN4http6header3map15hash_elem_using17h537579c3f4d36ef2E ' unrecognized
Warning: .drectve `-exclude-symbols:_ZN4http6header3map15hash_elem_using17h87cd6548dd606decE ' unrecognized
Warning: .drectve `-exclude-symbols:"_ZN4http6header3map18HeaderMap$LT$T$GT$15try_reserve_one17h7c7ed2b5c141b449E" ' unrecognized
Warning: .drectve `-exclude-symbols:"_ZN4http6header3map18HeaderMap$LT$T$GT$3get17h3ab23d7c46f55836E" ' unrecognized
Warning: .drectve `-exclude-symbols:"_ZN4http6header3map18HeaderMap$LT$T$GT$6remove17heb7890e9bad251bdE" ' unrecognized
Warning: .drectve `-exclude-symbols:"_ZN94_$LT$http..header..map..IterMut$LT$T$GT$$u20$as$u20$core..iter..traits..iterator..Iterator$GT$4next17h84e9e9fdd80ffea9E" ' unrecognized
Warning: .drectve `-exclude-symbols:"anon.eff80e8bfb70af4f19298714a1800963.1.llvm.1507271464599634379" ' unrecognized
Warning: .drectve `-exclude-symbols:"anon.eff80e8bfb70af4f19298714a1800963.3.llvm.1507271464599634379" ' unrecognized
Warning: .drectve `-exclude-symbols:"anon.eff80e8bfb70af4f19298714a1800963.5.llvm.1507271464599634379" ' unrecognized
Warning: corrupt .drectve at end of def file
Warning: .drectve `-exclude-symbols:"anon.6a844bffe2e34d1cdf3937e33681155a.6.llvm.16220265142764407797" ' unrecognized
Warning: .drectve `-exclude-symbols:"anon.6a844bffe2e34d1cdf3937e33681155a.7.llvm.16220265142764407797" ' unrecognized
Warning: .drectve `-exclude-symbols:"anon.6a844bffe2e34d1cdf3937e33681155a.22.llvm.16220265142764407797" ' unrecognized
Warning: corrupt .drectve at end of def file
Warning: .drectve `-exclude-symbols:"_ZN111_$LT$core..iter..adapters..zip..Zip$LT$A$C$B$GT$$u20$as$u20$core..iter..adapters..zip..ZipImpl$LT$A$C$B$GT$$GT$3new17h2fe90fc647383e96E" ' unrecognized
Warning: .drectve `-exclude-symbols:"_ZN111_$LT$core..iter..adapters..zip..Zip$LT$A$C$B$GT$$u20$as$u20$core..iter..adapters..zip..ZipImpl$LT$A$C$B$GT$$GT$3new17ha3a79dd495eca47cE" ' unrecognized
Warning: .drectve `-exclude-symbols:_ZN4core4iter8adapters3zip3zip17ha48e9a5504d32b8fE ' unrecognized
Warning: .drectve `-exclude-symbols:"_ZN79_$LT$alloc..vec..drain..Drain$LT$T$C$A$GT$$u20$as$u20$core..ops..drop..Drop$GT$4drop17h55c1172ba8225ebcE" ' unrecognized
Warning: .drectve `-exclude-symbols:"_ZN11tungstenite9handshake7machine30HandshakeMachine$LT$Stream$GT$10start_read17heda554637a9b78a5E" ' unrecognized
Warning: .drectve `-exclude-symbols:"_ZN11tungstenite9handshake7machine30HandshakeMachine$LT$Stream$GT$11start_write17h8d720c5f215a53dbE" ' unrecognized
Warning: .drectve `-exclude-symbols:"_ZN11tungstenite9handshake7machine30HandshakeMachine$LT$Stream$GT$12single_round17h81d430d7ae27b87aE" ' unrecognized
Warning: corrupt .drectve at end of def file
Warning: corrupt .drectve at end of def file
Warning: .drectve `-exclude-symbols:_ZN4core5slice4sort10merge_sort17h285d6f7e046046bcE ' unrecognized
Warning: .drectve `-exclude-symbols:_ZN4core5slice4sort10merge_sort17ha521faa48e79f2efE ' unrecognized
Warning: .drectve `-exclude-symbols:_ZN4core5slice4sort10merge_sort17hb92ed6c4e9e91e4bE ' unrecognized
Warning: .drectve `-exclude-symbols:_ZN4core5slice4sort10merge_sort17hc8a9d09f8cf6b118E ' unrecognized
Warning: .drectve `-exclude-symbols:_ZN4core5slice4sort10merge_sort17he5cd62023d9e4c07E ' unrecognized
Warning: .drectve `-exclude-symbols:"_ZN4core5slice4sort7recurse17h9dbcc7c80dd6b788E.llvm.15749623281044620870" ' unrecognized
Warning: corrupt .drectve at end of def file
Warning: .drectve `-exclude-symbols:"_ZN5alloc7raw_vec11finish_grow17h6ec16fd4024c94fbE.llvm.9310266364261148472" ' unrecognized
Warning: .drectve `-exclude-symbols:"_ZN5alloc7raw_vec19RawVec$LT$T$C$A$GT$16reserve_for_push17h487781049b07c366E" ' unrecognized
Warning: .drectve `-exclude-symbols:"_ZN5alloc7raw_vec19RawVec$LT$T$C$A$GT$16reserve_for_push17h7486c0bfe78c761fE" ' unrecognized
Warning: .drectve `-exclude-symbols:"_ZN5alloc7raw_vec19RawVec$LT$T$C$A$GT$7reserve21do_reserve_and_handle17h6fb2c0612895f77fE" ' unrecognized
Warning: .drectve `-exclude-symbols:"_ZN77_$LT$alloc..raw_vec..RawVec$LT$T$C$A$GT$$u20$as$u20$core..ops..drop..Drop$GT$4drop17h259a1e250fec0490E" ' unrecognized
Warning: corrupt .drectve at end of def file
Warning: .drectve `-exclude-symbols:"_ZN4core3ptr54drop_in_place$LT$gimli..read..abbrev..Abbreviation$GT$17h645f66ce73059aa7E.llvm.4948133945858239277" ' unrecognized
Warning: .drectve `-exclude-symbols:"_ZN5alloc11collections5btree4node115NodeRef$LT$alloc..collections..btree..node..marker..Mut$C$K$C$V$C$alloc..collections..btree..node..marker..Leaf$GT$4push17h60dbcccf5d5a5667E" ' unrecognized
Warning: .drectve `-exclude-symbols:"_ZN5alloc11collections5btree4node117NodeRef$LT$alloc..collections..btree..node..marker..Owned$C$K$C$V$C$alloc..collections..btree..node..marker..Leaf$GT$8new_leaf17h903f15adfc8d6eb2E" ' unrecognized
Warning: .drectve `-exclude-symbols:"_ZN5alloc11collections5btree4node171Handle$LT$alloc..collections..btree..node..NodeRef$LT$alloc..collections..btree..node..marker..Mut$C$K$C$V$C$NodeType$GT$$C$alloc..collections..btree..node..marker..KV$GT$12into_val_mut17hbbfd58c68fbfafd8E" ' unrecognized
Warning: .drectve `-exclude-symbols:"_ZN5alloc11collections5btree4node173Handle$LT$alloc..collections..btree..node..NodeRef$LT$alloc..collections..btree..node..marker..Immut$C$K$C$V$C$NodeType$GT$$C$alloc..collections..btree..node..marker..KV$GT$7into_kv17h5213a238fb50d7bfE" ' unrecognized
Warning: .drectve `-exclude-symbols:"_ZN5alloc11collections5btree4node210Handle$LT$alloc..collections..btree..node..NodeRef$LT$alloc..collections..btree..node..marker..Mut$C$K$C$V$C$alloc..collections..btree..node..marker..Leaf$GT$$C$alloc..collections..btree..node..marker..Edge$GT$16insert_recursing17h4a71a2c4a5cdcdebE" ' unrecognized
Warning: .drectve `-exclude-symbols:"_ZN5alloc11collections5btree6search142_$LT$impl$u20$alloc..collections..btree..node..NodeRef$LT$BorrowType$C$K$C$V$C$alloc..collections..btree..node..marker..LeafOrInternal$GT$$GT$11search_tree17h3572037653c91818E" ' unrecognized
Warning: .drectve `-exclude-symbols:"anon.993b8bc0275101d1fc7b716ea2bb232b.3.llvm.4948133945858239277" ' unrecognized
Warning: .drectve `-exclude-symbols:"anon.993b8bc0275101d1fc7b716ea2bb232b.4.llvm.4948133945858239277" ' unrecognized
Warning: .drectve `-exclude-symbols:"anon.993b8bc0275101d1fc7b716ea2bb232b.5.llvm.4948133945858239277" ' unrecognized
Warning: corrupt .drectve at end of def file
[939/940] Installing component bitcoin-qt-test_bitcoin-qt
-- Install configuration: "RelWithDebInfo"
-- Install component: "bitcoin-qt-test_bitcoin-qt"
-- Installing: /results/artifacts/bin/test_bitcoin-qt.exe
ninja: build stopped: cannot make progress due to previous errors.
Build build-win64 failed with exit code 1

Fabien planned changes to this revision.Sep 25 2024, 09:30

Try to fix the windows build

@bot build-win64 guix-win

teamcity updated a token.Sep 25 2024, 13:43

Fabien edited the summary of this revision. (Show Details)Sep 25 2024, 13:44

Harbormaster completed remote builds in B30418: Diff 49826.Sep 25 2024, 14:03

tobias_ruck accepted this revision.Sep 25 2024, 14:27

This revision is now accepted and ready to land.Sep 25 2024, 14:27

Closed by commit rABC9697427b4805: [iguana] Fix several build issues (authored by Fabien). · Explain WhySep 25 2024, 15:20

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC9697427b4805: [iguana] Fix several build issues.