Paths

Table of Contentst

Differential D16855

[token-server] Improve recaptcha handling
ClosedPublic
Actions

Authored by bytesofman on Oct 3 2024, 22:13.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC6a3ec8fdc5f4: [token-server] Improve recaptcha handling

Summary

Useful to see failed recaptchas in the logs. Also, no need to check validity of recaptcha if we do not get a recaptcha token.

Test Plan

npm test

Diff Detail

Repository

rABC Bitcoin ABC

Branch

recaptcha-debug-log

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 30494
Build 60505: Build Diff	token-server-tests
Build 60504: arc lint + arc unit

Event Timeline

bytesofman created this revision.Oct 3 2024, 22:13

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 3 2024, 22:13

better logs

bytesofman published this revision for review.Oct 3 2024, 22:14

Harbormaster completed remote builds in B30494: Diff 49943.Oct 3 2024, 22:15

Harbormaster completed remote builds in B30495: Diff 49944.

in the summary of the diff, did you mean "if we do not get a token" ? Otherwise looks good

This revision is now accepted and ready to land.Oct 4 2024, 07:34

bytesofman edited the summary of this revision. (Show Details)Oct 4 2024, 16:01

Closed by commit rABC6a3ec8fdc5f4: [token-server] Improve recaptcha handling (authored by bytesofman). · Explain WhyOct 4 2024, 16:03

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABC6a3ec8fdc5f4: [token-server] Improve recaptcha handling.

Revision Contents
Changeset List

Path

Size

apps/

token-server/

src/

routes.ts

10 lines

test/

routes.test.ts

29 lines

Diff 49943

View Options

apps/token-server/src/routes.ts