Page MenuHomePhabricator
Differential D16862

[herald] Fix the headers, lint the package
ClosedPublic
Actions

Authored by Fabien on Oct 7 2024, 08:56.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABCe36e63a307a6: [herald] Fix the headers, lint the package
Summary

The headers are enforced with a single year which is absurd. Update and lint all the files.

Test Plan
arc lint  -- apps/ecash-herald/**/*.js

Diff Detail

Repository
rABC Bitcoin ABC
Branch
herald_lint
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 30506
Build 60529: Build Diffecash-herald-tests
Build 60528: arc lint + arc unit

Event Timeline

Fabien created this revision.Oct 7 2024, 08:56
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 7 2024, 08:56
Fabien requested review of this revision.Oct 7 2024, 08:56
Harbormaster completed remote builds in B30506: Diff 49961.Oct 7 2024, 08:58
PiRK accepted this revision.Oct 7 2024, 13:15
PiRK added a subscriber: PiRK.
PiRK added inline comments.
apps/ecash-herald/.eslintrc.js
10

Good for another 9,75 centuries.
Are the brackets needed for the first digit ([2])?

This revision is now accepted and ready to land.Oct 7 2024, 13:15
Fabien added inline comments.Oct 7 2024, 13:22
apps/ecash-herald/.eslintrc.js
10

clearly not, I copy pasted this but the regex is indeed over-complicated for no reason

Fabien updated this revision to Diff 49962.Oct 7 2024, 13:24

Simplify the regex

Harbormaster completed remote builds in B30507: Diff 49962.Oct 7 2024, 13:26
Closed by commit rABCe36e63a307a6: [herald] Fix the headers, lint the package (authored by Fabien). · Explain WhyOct 7 2024, 15:06
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCe36e63a307a6: [herald] Fix the headers, lint the package.

Revision Contents
Changeset List

PathSize
apps/
ecash-herald/
21 lines
constants/
1 line
1 line
1 line
1 line
scripts/
1 line
1 line
1 line
src/
1 line
1 line
test/
1 line
fixtures/
1 line
1 line

Diff 49961

View Options

apps/ecash-herald/.eslintrc.js

Loading...
View Options

apps/ecash-herald/constants/addresses.js

Loading...
View Options

apps/ecash-herald/constants/miners.js

Loading...
View Options

apps/ecash-herald/constants/op_return.js

Loading...
View Options

apps/ecash-herald/constants/tokens.js

Loading...
View Options

apps/ecash-herald/scripts/generateMock.js

Loading...
View Options

apps/ecash-herald/scripts/getSlpTwoTokenInfo.js

Loading...
View Options

apps/ecash-herald/scripts/sendMsgByBlock.js

Loading...
View Options

apps/ecash-herald/src/chronik.js

Loading...
View Options

apps/ecash-herald/src/events.js

Loading...
View Options

apps/ecash-herald/test/chronik.test.js

Loading...
View Options

apps/ecash-herald/test/fixtures/miners.js

Loading...
View Options

apps/ecash-herald/test/fixtures/stakers.js

Loading...