[electrum] update block explorers
ClosedPublic
Actions

Authored by PiRK on Wed, Oct 9, 07:32.

Details

Reviewers

bytesofman

Group Reviewers

Restricted Project

Commits

rABC2073152fee90: [electrum] update block explorers

Summary

[t]explorer.bitcoinabc.org is going to be retired soon.

explorer.viawallet.com has been a redirect to expplorer.coinex.com for a
while now.

Add texplorer.e.cash

Users who previously selected [t]explorer.bitcoinabc.org will switch
to using the default explorer, which is [t]explorer.e.cash

For users who selected explorer.viawallet.com this diff adds some code to
automatically switch to coinex.explorer.com.

Test Plan

Test that all the explorer still work, both for transactions (History
tab) and for address URLs (Address tab).

Edit ~/.electrum-abc/config, set "block_explorer": "ViaWallet",
bump the version in version.py to trigger the update,
check that the "CoinEx" explorer is selected in the configuration menu.
Check that the line in config was
updated to "block_explorer": "CoinEx"

Diff Detail

Repository

rABC Bitcoin ABC

Branch

electrum_explorer

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 30535
Build 60586: Build Diff	electrum-tests
Build 60585: arc lint + arc unit

Event Timeline

PiRK created this revision.Wed, Oct 9, 07:32

Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Oct 9, 07:32

PiRK requested review of this revision.Wed, Oct 9, 07:32

Harbormaster completed remote builds in B30535: Diff 50005.Wed, Oct 9, 07:34

not a blocker, but mb worth noting

if you

set explorer to bitcoinabc
close electrum
arc patch this diff
./electrum-abc

then check out preferences

looks like "no" explorer is selected. However, if you click to see txs in the explorer, it does use explorer.e.cash

if you do the same but with "ViaWallet", it works and also appears as selected in preferences

This revision is now accepted and ready to land.Wed, Oct 9, 12:55

In D16875#382821, @bytesofman wrote:

not a blocker, but mb worth noting

if you

set explorer to bitcoinabc

close electrum

arc patch this diff

./electrum-abc

then check out preferences

looks like "no" explorer is selected. However, if you click to see txs in the explorer, it does use explorer.e.cash

if you do the same but with "ViaWallet", it works and also appears as selected in preferences

Yes, I didn't bother to add an upgrade path for the BitcoinABC -> eCash transition, because any invalide/unknown value for the block_explorer config field will result in using the default, which is the one we want. Also about a year ago we force-upgraded people who selected BitcoinABC to eCash, so there are probably not many people left with this setting (only a few power users who really preferred the Bitcoin ABC explorer for some reason and selected it back). I'll check if I can make the widget properly reflect the default selection, instead of showing blank.