Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Summary

Import the rust-secp256k1 repository, and apply the following modifications:

Removed the secp256k1 library imported from bitcoin-core, as well as all the vendoring code
Use our secp256k1 library of the monorepo
Add schnorrabc, which are the Schnorr signatures used by ABC. These are distinct from the x-only pubkey BIP340 signatures from BTC, but not removed here, to allow for easier backports.
Removed a lot of GitHub CI related files. Sophisticated CI can be added later. NB: This also disables most of the tests, but those are not very simple to set up. For now, we only do the integration tests with ecash-lib and ecash-agora.
Adapt the Rust workspace structure to our workspace.
Reformat everything with our formatting rules.

Test Plan

./build-wasm.sh, and then run the integration tests using ecash-lib

Diff Detail

Repository

rABC Bitcoin ABC

Branch

ecash-lib-rust-secp256k1

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 30598
Build 60712: Build Diff
Build 60711: arc lint + arc unit

Event Timeline

tobias_ruck created this revision.Oct 14 2024, 19:00

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 14 2024, 19:00

Harbormaster completed remote builds in B30591: Diff 50089.Oct 14 2024, 19:00

@bot ecash-lib-integration-tests

teamcity awarded a token.Oct 14 2024, 19:02

Build Bitcoin ABC Diffs / Diff Testing (ecash-lib-integration-tests) failed.

Tail of the build log:

    '/work/modules/ecash-lib/src/ffi/ecash_lib_wasm_nodejs.js',
    '/work/modules/ecash-lib/src/initNodeJs.ts',
    '/work/modules/ecash-lib/tests/alp.test.ts'
  ]
}
----------------------------|---------|----------|---------|---------|-------------------
File                        | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s 
----------------------------|---------|----------|---------|---------|-------------------
All files                   |    1.24 |     3.82 |    1.56 |    1.27 |                   
 ecash-lib                  |       0 |        0 |       0 |       0 |                   
  eslint.config.js          |       0 |        0 |       0 |       0 |                   
 ecash-lib/src              |    2.34 |     7.53 |    4.28 |    2.36 |                   
  consts.ts                 |       0 |      100 |     100 |       0 | 6-8               
  ecc.ts                    |   42.85 |    83.33 |      20 |   42.85 | 23-31,36          
  hash.ts                   |   55.55 |    83.33 |      20 |   55.55 | 14,17,20,24       
  index.ts                  |       0 |        0 |       0 |       0 |                   
  indexBrowser.ts           |       0 |        0 |       0 |       0 |                   
  indexNodeJs.ts            |       0 |        0 |       0 |       0 |                   
  initBrowser.ts            |       0 |      100 |       0 |       0 | 11-13             
  initNodeJs.ts             |   42.85 |    83.33 |      50 |      50 | 7-11              
  op.ts                     |       0 |        0 |       0 |       0 | 33-161            
  opcode.ts                 |       0 |      100 |     100 |       0 | 10-154            
  script.ts                 |       0 |        0 |       0 |       0 | 28-199            
  sigHashType.ts            |       0 |        0 |       0 |       0 | 19-166            
  tx.ts                     |       0 |        0 |       0 |       0 | 21-176            
  txBuilder.ts              |       0 |        0 |       0 |       0 | 74-240            
  unsignedTx.ts             |       0 |        0 |       0 |       0 | 38-229            
 ecash-lib/src/ffi          |    0.92 |        0 |       0 |    0.94 |                   
  ecash_lib_wasm_browser.js |       0 |        0 |       0 |       0 | 5-339             
  ecash_lib_wasm_nodejs.js  |    2.02 |        0 |       0 |    2.05 | 5-265             
 ecash-lib/src/io           |       0 |        0 |       0 |       0 |                   
  bytes.ts                  |       0 |        0 |       0 |       0 | 13-64             
  hex.ts                    |       0 |        0 |       0 |       0 | 5-68              
  int.ts                    |       0 |        0 |       0 |       0 |                   
  str.ts                    |       0 |      100 |       0 |       0 | 5-15              
  varsize.ts                |       0 |        0 |       0 |       0 | 14-47             
  writer.ts                 |       0 |        0 |       0 |       0 |                   
  writerbytes.ts            |       0 |        0 |       0 |       0 | 21-79             
  writerlength.ts           |       0 |      100 |       0 |       0 | 16-41             
 ecash-lib/src/test         |       0 |        0 |       0 |       0 |                   
  testRunner.ts             |       0 |        0 |       0 |       0 | 17-207            
 ecash-lib/src/token        |       0 |        0 |       0 |       0 |                   
  alp.ts                    |       0 |        0 |       0 |       0 | 13-145            
  common.ts                 |       0 |      100 |     100 |       0 | 9-12              
  empp.ts                   |       0 |        0 |       0 |       0 | 11-28             
  slp.ts                    |       0 |        0 |       0 |       0 | 13-211            
----------------------------|---------|----------|---------|---------|-------------------

##teamcity[blockOpened name='Code Coverage Summary']
##teamcity[buildStatisticValue key='CodeCoverageAbsBCovered' value='14']
##teamcity[buildStatisticValue key='CodeCoverageAbsBTotal' value='1123']
##teamcity[buildStatisticValue key='CodeCoverageAbsRCovered' value='15']
##teamcity[buildStatisticValue key='CodeCoverageAbsRTotal' value='392']
##teamcity[buildStatisticValue key='CodeCoverageAbsMCovered' value='3']
##teamcity[buildStatisticValue key='CodeCoverageAbsMTotal' value='192']
##teamcity[buildStatisticValue key='CodeCoverageAbsLCovered' value='14']
##teamcity[buildStatisticValue key='CodeCoverageAbsLTotal' value='1102']
##teamcity[blockClosed name='Code Coverage Summary']
mv: cannot stat 'test_results/ecash-lib-integration-tests-junit.xml': No such file or directory
Build ecash-lib-integration-tests failed with exit code 1

fix wasm linker issues

Harbormaster completed remote builds in B30595: Diff 50094.Oct 14 2024, 20:45

@bot ecash-lib-integration-tests

teamcity updated a token.Oct 14 2024, 20:47

remove link name

Harbormaster completed remote builds in B30597: Diff 50098.Oct 14 2024, 22:21

remove some more stuff

Harbormaster completed remote builds in B30598: Diff 50099.Oct 14 2024, 22:36

@bot ecash-lib-integration-tests ecash-agora-integration-tests

teamcity updated a token.Oct 14 2024, 22:37

tobias_ruck published this revision for review.Oct 14 2024, 22:38

tobias_ruck edited the summary of this revision. (Show Details)Oct 14 2024, 22:43

add rust-secp256k1 to the rust workspace

Harbormaster completed remote builds in B30600: Diff 50104.Oct 15 2024, 07:00

I'm very happy to see this happen but there is no way to review such a change. You really need to split it into pieces, starting with running the ecash-lib integration tests properly on CI when there is a relevant change, which seems to not be the case here.
Then you can go through the list that is in the summary.

This revision now requires changes to proceed.Oct 15 2024, 07:15

tobias_ruck abandoned this revision.Thu, Oct 24, 13:17

[ecash-lib] Add `rust-secp256k1`, use in `ecash-lib-wasm`
AbandonedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 50099

Cargo.lock

Cargo.toml

modules/ecash-lib-wasm/Cargo.toml

modules/ecash-lib-wasm/src/ecc.rs

modules/rust-secp256k1/.gitignore

modules/rust-secp256k1/Cargo.toml

modules/rust-secp256k1/LICENSE

modules/rust-secp256k1/README.md

modules/rust-secp256k1/secp256k1-sys/Cargo.toml

modules/rust-secp256k1/secp256k1-sys/LICENSE

modules/rust-secp256k1/secp256k1-sys/build.rs

modules/rust-secp256k1/secp256k1-sys/src/lib.rs

modules/rust-secp256k1/secp256k1-sys/src/macros.rs

modules/rust-secp256k1/secp256k1-sys/src/recovery.rs

modules/rust-secp256k1/secp256k1-sys/src/types.rs

modules/rust-secp256k1/secp256k1-sys/wasm/wasm-sysroot/stdio.h

modules/rust-secp256k1/secp256k1-sys/wasm/wasm-sysroot/stdlib.h

modules/rust-secp256k1/secp256k1-sys/wasm/wasm-sysroot/string.h

modules/rust-secp256k1/secp256k1-sys/wasm/wasm.c

modules/rust-secp256k1/src/constants.rs

modules/rust-secp256k1/src/context.rs

modules/rust-secp256k1/src/ecdh.rs

modules/rust-secp256k1/src/ecdsa/mod.rs

modules/rust-secp256k1/src/ecdsa/recovery.rs

modules/rust-secp256k1/src/ecdsa/serialized_signature.rs

modules/rust-secp256k1/src/key.rs

modules/rust-secp256k1/src/lib.rs

modules/rust-secp256k1/src/macros.rs

modules/rust-secp256k1/src/scalar.rs

modules/rust-secp256k1/src/schnorr.rs

modules/rust-secp256k1/src/schnorrabc.rs

modules/rust-secp256k1/src/secret.rs

modules/rust-secp256k1/src/serde_util.rs

modules/rust-secp256k1/tests/serde.rs

[ecash-lib] Add `rust-secp256k1`, use in `ecash-lib-wasm`AbandonedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 50099

Cargo.lock

Cargo.toml

modules/ecash-lib-wasm/Cargo.toml

modules/ecash-lib-wasm/src/ecc.rs

modules/rust-secp256k1/.gitignore

modules/rust-secp256k1/Cargo.toml

modules/rust-secp256k1/LICENSE

modules/rust-secp256k1/README.md

modules/rust-secp256k1/secp256k1-sys/Cargo.toml

modules/rust-secp256k1/secp256k1-sys/LICENSE

modules/rust-secp256k1/secp256k1-sys/build.rs

modules/rust-secp256k1/secp256k1-sys/src/lib.rs

modules/rust-secp256k1/secp256k1-sys/src/macros.rs

modules/rust-secp256k1/secp256k1-sys/src/recovery.rs

modules/rust-secp256k1/secp256k1-sys/src/types.rs

modules/rust-secp256k1/secp256k1-sys/wasm/wasm-sysroot/stdio.h

modules/rust-secp256k1/secp256k1-sys/wasm/wasm-sysroot/stdlib.h

modules/rust-secp256k1/secp256k1-sys/wasm/wasm-sysroot/string.h

modules/rust-secp256k1/secp256k1-sys/wasm/wasm.c

modules/rust-secp256k1/src/constants.rs

modules/rust-secp256k1/src/context.rs

modules/rust-secp256k1/src/ecdh.rs

modules/rust-secp256k1/src/ecdsa/mod.rs

modules/rust-secp256k1/src/ecdsa/recovery.rs

modules/rust-secp256k1/src/ecdsa/serialized_signature.rs

modules/rust-secp256k1/src/key.rs

modules/rust-secp256k1/src/lib.rs

modules/rust-secp256k1/src/macros.rs

modules/rust-secp256k1/src/scalar.rs

modules/rust-secp256k1/src/schnorr.rs

modules/rust-secp256k1/src/schnorrabc.rs

modules/rust-secp256k1/src/secret.rs

modules/rust-secp256k1/src/serde_util.rs

modules/rust-secp256k1/tests/serde.rs

[ecash-lib] Add `rust-secp256k1`, use in `ecash-lib-wasm`
AbandonedPublic
Actions

Revision Contents
Changeset List