Page MenuHomePhabricator

[cmake] Remove redundant find_package(Python)
ClosedPublic

Authored by Fabien on Oct 21 2024, 16:09.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABC989ecb89d1bc: [cmake] Remove redundant find_package(Python)
Summary

These calls are no-op because the FindPython for the interpreter is already called in the main CMakeLists.txt (and the variable is cached). Also these calls don't make it mandatory nor enforce a minimum version which is confusing.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Branch
remove_redundant_find_python
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 30706
Build 60928: Build Difflint-circular-dependencies · build-without-wallet · build-debug · build-diff · build-clang-tidy · build-clang
Build 60927: arc lint + arc unit

Event Timeline

Fabien requested review of this revision.Oct 21 2024, 16:09
Fabien updated this revision to Diff 50244.

Python3_EXECUTABLE => Python_EXECUTABLE

This revision is now accepted and ready to land.Oct 21 2024, 19:11