Page MenuHomePhabricator
Differential D16947

[cmake] Remove redundant find_package(Python)
ClosedPublic
Actions

Authored by Fabien on Mon, Oct 21, 16:09.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABC989ecb89d1bc: [cmake] Remove redundant find_package(Python)
Summary

These calls are no-op because the FindPython for the interpreter is already called in the main CMakeLists.txt (and the variable is cached). Also these calls don't make it mandatory nor enforce a minimum version which is confusing.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Branch
remove_redundant_find_python
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 30706
Build 60928: Build Difflint-circular-dependencies · build-without-wallet · build-debug · build-diff · build-clang-tidy · build-clang
Build 60927: arc lint + arc unit

Event Timeline

Fabien created this revision.Mon, Oct 21, 16:09
Herald added a reviewer: Restricted Project. · View Herald TranscriptMon, Oct 21, 16:09
Fabien requested review of this revision.Mon, Oct 21, 16:09
Fabien updated this revision to Diff 50244.

Python3_EXECUTABLE => Python_EXECUTABLE

Harbormaster completed remote builds in B30705: Diff 50243.Mon, Oct 21, 17:06
Harbormaster completed remote builds in B30706: Diff 50244.Mon, Oct 21, 17:10
PiRK accepted this revision.Mon, Oct 21, 19:11
This revision is now accepted and ready to land.Mon, Oct 21, 19:11
Closed by commit rABC989ecb89d1bc: [cmake] Remove redundant find_package(Python) (authored by Fabien). · Explain WhyMon, Oct 21, 19:20
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC989ecb89d1bc: [cmake] Remove redundant find_package(Python).

Revision Contents
Changeset List

PathSize
cmake/
modules/
3 lines
src/
iguana/
2 lines

Diff 50244

View Options

cmake/modules/Coverage.cmake

Loading...
View Options

src/iguana/CMakeLists.txt

Loading...