Page MenuHomePhabricator

[Cashtab] Add max qty validation to isValidTokenSendOrBurnAmount
ClosedPublic

Authored by bytesofman on Oct 21 2024, 17:47.

Details

Summary

Depends on D16949

This has been overlooked in Cashtab. In practice, most users would not have a balance of a token greater than this amount (since it takes multiple max-qty mint txs and token markets are not yet supported).

It is part of the spec tho, and may not be an edge case for long. Add it.

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
token-validation-fix
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 30710
Build 60936: Build Diffcashtab-tests · ecash-lib-tests
Build 60935: arc lint + arc unit

Event Timeline

PiRK added a subscriber: PiRK.
PiRK added inline comments.
cashtab/src/validation/fixtures/vectors.js
1965 ↗(On Diff #50250)

"more less"?

This revision is now accepted and ready to land.Oct 21 2024, 19:47