Page MenuHomePhabricator

[Iguana] Display empty stack items as `""`
ClosedPublic

Authored by tobias_ruck on Oct 24 2024, 10:07.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCde1c383640b3: [Iguana] Display empty stack items as `""`
Summary

Currently, empty stack items are simply displayed as the empty string, however, in practice this is somewhat confusing.

Instead, we display "", which is easy to understand and also consistent with how the empty string is displayed on the explorer.

Note that the explorer also displays hex strings prefixed with "0x", which might be appropriate for stack items for iguana, too.

In the future, we could check if the encoded bytes are all ASCII (including \0) and display the decoded ASCII in quotes.

Test Plan

ninja check-iguana

Diff Detail