Page MenuHomePhabricator

[Cashtab] Attempt to patch agora-crashing bug
ClosedPublic

Authored by bytesofman on Oct 26 2024, 18:29.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC2c69f9fdaad5: [Cashtab] Attempt to patch agora-crashing bug
Summary

Difficult to say if this will fix things as I can't repeat this locally, though users are clearly affected. based on debug logs, looks like crash is caused by the toHex function being called in the OrderBook component. This is only called 4 times -- and 2 of those times are not on load, only when a function is called.

Wrap calls in try...catch and add debug log to see if this is the issue.

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
another-bug-patch-attempt
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 30855
Build 61223: Build Diffcashtab-tests
Build 61222: arc lint + arc unit

Event Timeline

Fabien added inline comments.
cashtab/src/components/Agora/OrderBook.js
349

According to the above comment you should check for null. Otherwise you will get logs for sure, but not for the good reason

bytesofman added inline comments.
cashtab/src/components/Agora/OrderBook.js
349

activePk could be null as it is set this way before the app loads, but i want to see what's actually in the debug log to make sure it's not some issue in loading makerPk from the offer

will correct the code when I know what the issue is

This revision is now accepted and ready to land.Oct 26 2024, 18:54
This revision was automatically updated to reflect the committed changes.
bytesofman marked an inline comment as done.