[Cashtab] Attempt to patch agora-crashing bug
ClosedPublic
Actions

Authored by bytesofman on Oct 26 2024, 18:29.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC2c69f9fdaad5: [Cashtab] Attempt to patch agora-crashing bug

Summary

Difficult to say if this will fix things as I can't repeat this locally, though users are clearly affected. based on debug logs, looks like crash is caused by the toHex function being called in the OrderBook component. This is only called 4 times -- and 2 of those times are not on load, only when a function is called.

Wrap calls in try...catch and add debug log to see if this is the issue.

Test Plan

npm test

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bytesofman created this revision.Oct 26 2024, 18:29

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 26 2024, 18:29

bytesofman published this revision for review.Oct 26 2024, 18:41

Fabien added a subscriber: Fabien.Oct 26 2024, 18:48

Fabien added inline comments.

cashtab/src/components/Agora/OrderBook.js
349 ↗	(On Diff #50460)	According to the above comment you should check for null. Otherwise you will get logs for sure, but not for the good reason

bytesofman marked an inline comment as done.Oct 26 2024, 18:54

bytesofman added inline comments.

cashtab/src/components/Agora/OrderBook.js
349 ↗	(On Diff #50460)	activePk could be null as it is set this way before the app loads, but i want to see what's actually in the debug log to make sure it's not some issue in loading makerPk from the offer will correct the code when I know what the issue is