Details

Reviewers

emack

Group Reviewers

Restricted Project

Commits

rABCc029196d5004: [ecash-herald] Parse agora actions

Summary

Summarize SLP1 agora partial txs in daily summary

We now use ecash-lib and ecash-agora in ecash-herald, so update CI settings and herald dockerfile

Arguably ecash-agora does not need to be imported to the herald yet, we could do the agora parsing without it. However, we will for sure need it later if we want to add volume metrics, which we do. So might as well add it and update the CI stuff now.

Test Plan

npm test, see screenshot

docker build -f ecash-herald.Dockerfile -t ecash-herald_local . for new docker file

CI tests to confirm ecash-agora change does not impact the lib or other apps using it

last 24 hrs:

Diff Detail

Repository

rABC Bitcoin ABC

Branch

summaries-better-tokens

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 30867
Build 61247: Build Diff	ecash-agora-integration-tests · ecash-herald-tests · cashtab-tests · ecash-agora-tests
Build 61246: arc lint + arc unit

Event Timeline

bytesofman created this revision.Sun, Oct 27, 15:28

Herald added a reviewer: Restricted Project. · View Herald TranscriptSun, Oct 27, 15:28

clean up comments

Harbormaster completed remote builds in B30863: Diff 50472.Sun, Oct 27, 15:30

Build Bitcoin ABC Diffs / Diff Testing (ecash-herald-tests) failed.

Tail of the build log:

    at require (node:internal/modules/helpers:179:18)
    at Object.<anonymous> (/work/apps/ecash-herald/src/chronikWsHandler.js:5:168)
    at Module._compile (node:internal/modules/cjs/loader:1469:14)
    at Module.replacementCompile (/usr/lib/node_modules/nyc/node_modules/append-transform/index.js:60:13)
    at Module._extensions..js (node:internal/modules/cjs/loader:1548:10)
    at Object.<anonymous> (/usr/lib/node_modules/nyc/node_modules/append-transform/index.js:64:4)
    at Module.load (node:internal/modules/cjs/loader:1288:32)
    at Module._load (node:internal/modules/cjs/loader:1104:12)
    at Module.require (node:internal/modules/cjs/loader:1311:19)
    at require (node:internal/modules/helpers:179:18)
    at Object.<anonymous> (/work/apps/ecash-herald/test/chronikWsHandler.test.js:16:5)
    at Module._compile (node:internal/modules/cjs/loader:1469:14)
    at Module.replacementCompile (/usr/lib/node_modules/nyc/node_modules/append-transform/index.js:60:13)
    at Module._extensions..js (node:internal/modules/cjs/loader:1548:10)
    at Object.<anonymous> (/usr/lib/node_modules/nyc/node_modules/append-transform/index.js:64:4)
    at Module.load (node:internal/modules/cjs/loader:1288:32)
    at Module._load (node:internal/modules/cjs/loader:1104:12)
    at cjsLoader (node:internal/modules/esm/translators:346:17)
    at ModuleWrap.<anonymous> (node:internal/modules/esm/translators:286:7)
    at ModuleJob.run (node:internal/modules/esm/module_job:234:25)
    at async ModuleLoader.import (node:internal/modules/esm/loader:473:24)
    at async formattedImport (/work/apps/ecash-herald/node_modules/mocha/lib/nodejs/esm-utils.js:9:14)
    at async exports.requireOrImport (/work/apps/ecash-herald/node_modules/mocha/lib/nodejs/esm-utils.js:42:28)
    at async exports.loadFilesAsync (/work/apps/ecash-herald/node_modules/mocha/lib/nodejs/esm-utils.js:100:20)
    at async singleRun (/work/apps/ecash-herald/node_modules/mocha/lib/cli/run-helpers.js:125:3)
    at async exports.handler (/work/apps/ecash-herald/node_modules/mocha/lib/cli/run.js:370:5)
------------------------|---------|----------|---------|---------|-------------------
File                    | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s 
------------------------|---------|----------|---------|---------|-------------------
All files               |    5.12 |     1.93 |    1.31 |    5.15 |                   
 ecash-herald           |     100 |      100 |     100 |     100 |                   
  config.js             |     100 |      100 |     100 |     100 |                   
 ecash-herald/constants |     100 |      100 |     100 |     100 |                   
  addresses.js          |     100 |      100 |     100 |     100 |                   
  lokad.js              |     100 |      100 |     100 |     100 |                   
  miners.js             |     100 |      100 |     100 |     100 |                   
  op_return.js          |     100 |      100 |     100 |     100 |                   
  senders.js            |     100 |      100 |     100 |     100 |                   
  tokens.js             |     100 |      100 |     100 |     100 |                   
 ecash-herald/src       |    3.47 |     1.93 |    1.31 |    3.47 |                   
  chronik.js            |    4.65 |        0 |       0 |     4.7 | 14-249            
  chronikWsHandler.js   |    7.69 |        0 |       0 |    7.69 | 8-78              
  events.js             |    5.35 |        0 |       0 |    5.45 | 19-268            
  parse.js              |    1.56 |        0 |       0 |    1.59 | 31-3277           
  telegram.js           |    6.81 |        0 |       0 |    7.14 | 19-148            
  utils.js              |   11.24 |    14.14 |    5.55 |   10.97 | 15-255,303-441    
------------------------|---------|----------|---------|---------|-------------------

##teamcity[blockOpened name='Code Coverage Summary']
##teamcity[buildStatisticValue key='CodeCoverageAbsBCovered' value='66']
##teamcity[buildStatisticValue key='CodeCoverageAbsBTotal' value='1287']
##teamcity[buildStatisticValue key='CodeCoverageAbsRCovered' value='14']
##teamcity[buildStatisticValue key='CodeCoverageAbsRTotal' value='725']
##teamcity[buildStatisticValue key='CodeCoverageAbsMCovered' value='1']
##teamcity[buildStatisticValue key='CodeCoverageAbsMTotal' value='76']
##teamcity[buildStatisticValue key='CodeCoverageAbsLCovered' value='65']
##teamcity[buildStatisticValue key='CodeCoverageAbsLTotal' value='1260']
##teamcity[blockClosed name='Code Coverage Summary']
mv: cannot stat 'test_results/ecash-herald-junit.xml': No such file or directory
Build ecash-herald-tests failed with exit code 1

Harbormaster completed remote builds in B30864: Diff 50473.Sun, Oct 27, 15:32

Build Bitcoin ABC Diffs / Diff Testing (ecash-herald-tests) failed.

Tail of the build log:

    at require (node:internal/modules/helpers:179:18)
    at Object.<anonymous> (/work/apps/ecash-herald/src/chronikWsHandler.js:5:168)
    at Module._compile (node:internal/modules/cjs/loader:1469:14)
    at Module.replacementCompile (/usr/lib/node_modules/nyc/node_modules/append-transform/index.js:60:13)
    at Module._extensions..js (node:internal/modules/cjs/loader:1548:10)
    at Object.<anonymous> (/usr/lib/node_modules/nyc/node_modules/append-transform/index.js:64:4)
    at Module.load (node:internal/modules/cjs/loader:1288:32)
    at Module._load (node:internal/modules/cjs/loader:1104:12)
    at Module.require (node:internal/modules/cjs/loader:1311:19)
    at require (node:internal/modules/helpers:179:18)
    at Object.<anonymous> (/work/apps/ecash-herald/test/chronikWsHandler.test.js:16:5)
    at Module._compile (node:internal/modules/cjs/loader:1469:14)
    at Module.replacementCompile (/usr/lib/node_modules/nyc/node_modules/append-transform/index.js:60:13)
    at Module._extensions..js (node:internal/modules/cjs/loader:1548:10)
    at Object.<anonymous> (/usr/lib/node_modules/nyc/node_modules/append-transform/index.js:64:4)
    at Module.load (node:internal/modules/cjs/loader:1288:32)
    at Module._load (node:internal/modules/cjs/loader:1104:12)
    at cjsLoader (node:internal/modules/esm/translators:346:17)
    at ModuleWrap.<anonymous> (node:internal/modules/esm/translators:286:7)
    at ModuleJob.run (node:internal/modules/esm/module_job:234:25)
    at async ModuleLoader.import (node:internal/modules/esm/loader:473:24)
    at async formattedImport (/work/apps/ecash-herald/node_modules/mocha/lib/nodejs/esm-utils.js:9:14)
    at async exports.requireOrImport (/work/apps/ecash-herald/node_modules/mocha/lib/nodejs/esm-utils.js:42:28)
    at async exports.loadFilesAsync (/work/apps/ecash-herald/node_modules/mocha/lib/nodejs/esm-utils.js:100:20)
    at async singleRun (/work/apps/ecash-herald/node_modules/mocha/lib/cli/run-helpers.js:125:3)
    at async exports.handler (/work/apps/ecash-herald/node_modules/mocha/lib/cli/run.js:370:5)
------------------------|---------|----------|---------|---------|-------------------
File                    | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s 
------------------------|---------|----------|---------|---------|-------------------
All files               |    5.12 |     1.93 |    1.31 |    5.15 |                   
 ecash-herald           |     100 |      100 |     100 |     100 |                   
  config.js             |     100 |      100 |     100 |     100 |                   
 ecash-herald/constants |     100 |      100 |     100 |     100 |                   
  addresses.js          |     100 |      100 |     100 |     100 |                   
  lokad.js              |     100 |      100 |     100 |     100 |                   
  miners.js             |     100 |      100 |     100 |     100 |                   
  op_return.js          |     100 |      100 |     100 |     100 |                   
  senders.js            |     100 |      100 |     100 |     100 |                   
  tokens.js             |     100 |      100 |     100 |     100 |                   
 ecash-herald/src       |    3.47 |     1.93 |    1.31 |    3.47 |                   
  chronik.js            |    4.65 |        0 |       0 |     4.7 | 14-249            
  chronikWsHandler.js   |    7.69 |        0 |       0 |    7.69 | 8-78              
  events.js             |    5.35 |        0 |       0 |    5.45 | 19-268            
  parse.js              |    1.56 |        0 |       0 |    1.59 | 31-3275           
  telegram.js           |    6.81 |        0 |       0 |    7.14 | 19-148            
  utils.js              |   11.24 |    14.14 |    5.55 |   10.97 | 15-255,303-441    
------------------------|---------|----------|---------|---------|-------------------

##teamcity[blockOpened name='Code Coverage Summary']
##teamcity[buildStatisticValue key='CodeCoverageAbsBCovered' value='66']
##teamcity[buildStatisticValue key='CodeCoverageAbsBTotal' value='1287']
##teamcity[buildStatisticValue key='CodeCoverageAbsRCovered' value='14']
##teamcity[buildStatisticValue key='CodeCoverageAbsRTotal' value='725']
##teamcity[buildStatisticValue key='CodeCoverageAbsMCovered' value='1']
##teamcity[buildStatisticValue key='CodeCoverageAbsMTotal' value='76']
##teamcity[buildStatisticValue key='CodeCoverageAbsLCovered' value='65']
##teamcity[buildStatisticValue key='CodeCoverageAbsLTotal' value='1260']
##teamcity[blockClosed name='Code Coverage Summary']
mv: cannot stat 'test_results/ecash-herald-junit.xml': No such file or directory
Build ecash-herald-tests failed with exit code 1

update config yml to install new dependencies for herald

Harbormaster completed remote builds in B30865: Diff 50474.Sun, Oct 27, 15:35

updating docker file

bytesofman edited the test plan for this revision. (Show Details)Sun, Oct 27, 15:44

update ecash-agora changelog

bytesofman edited the summary of this revision. (Show Details)Sun, Oct 27, 15:46

Harbormaster completed remote builds in B30866: Diff 50475.Sun, Oct 27, 15:52

Harbormaster completed remote builds in B30867: Diff 50476.Sun, Oct 27, 15:55

bytesofman published this revision for review.Sun, Oct 27, 16:04

bytesofman added inline comments.

contrib/teamcity/build-configurations.yml
126	we'll probably need this var for `token-server` soon
modules/ecash-agora/tsconfig.json
8	I ran into this issue before trying to use `ecash-agora` in a nodejs typescript app These compile settings don't let you import it. It works in Cashtab because of Cashtab's webpack settings. So, we could isolate this change, but this diff is the first where we need it in the monorepo, and the CI here confirms it works as intended

bytesofman edited the test plan for this revision. (Show Details)Sun, Oct 27, 16:30

emack requested changes to this revision.Mon, Oct 28, 12:39

emack added a subscriber: emack.

emack added inline comments.

apps/ecash-herald/src/parse.js
2444	incomplete sentence?
2460–2490	this block is near identical across list, buy, adprep and sell, with the only difference being the words 'list', 'buy', 'adprep' or 'sell'. Can save about 100 lines of code if you use `eval` to reference the action for both attribute and string.

This revision now requires changes to proceed.Mon, Oct 28, 12:39

clean up comments, make map updater portable for count-only actions

Harbormaster completed remote builds in B30876: Diff 50488.Mon, Oct 28, 17:51

emack accepted this revision.Tue, Oct 29, 12:26

This revision is now accepted and ready to land.Tue, Oct 29, 12:26

Closed by commit rABCc029196d5004: [ecash-herald] Parse agora actions (authored by bytesofman). · Explain WhyTue, Oct 29, 13:06

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABCc029196d5004: [ecash-herald] Parse agora actions.

[ecash-herald] Parse agora actions
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 50476

apps/ecash-herald/config.js

apps/ecash-herald/package-lock.json

apps/ecash-herald/package.json

apps/ecash-herald/src/parse.js

apps/ecash-herald/test/mocks/dailyTxs.js

apps/ecash-herald/test/parse.test.js

contrib/teamcity/build-configurations.yml

ecash-herald.Dockerfile

modules/ecash-agora/README.md

modules/ecash-agora/package.json

modules/ecash-agora/tsconfig.json

[ecash-herald] Parse agora actionsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 50476

apps/ecash-herald/config.js

apps/ecash-herald/package-lock.json

apps/ecash-herald/package.json

apps/ecash-herald/src/parse.js

apps/ecash-herald/test/mocks/dailyTxs.js

apps/ecash-herald/test/parse.test.js

contrib/teamcity/build-configurations.yml

ecash-herald.Dockerfile

modules/ecash-agora/README.md

modules/ecash-agora/package.json

modules/ecash-agora/tsconfig.json

[ecash-herald] Parse agora actions
ClosedPublic
Actions

Revision Contents
Changeset List