[Cashtab] Use token-server blacklist for agora
ClosedPublic
Actions

Authored by bytesofman on Tue, Oct 29, 14:04.

Details

Reviewers

emack

Group Reviewers

Restricted Project

Commits

Summary

We have a database blacklist live now that we can update without submitting diffs. Use that.

Fall back to local blacklist on error.

Test Plan

npm test

Repository

rABC Bitcoin ABC

Branch

use-token-server-blacklist

Lint

Lint Passed

Unit

No Test Coverage

Build Status

bytesofman published this revision for review.Tue, Oct 29, 14:28

emack requested changes to this revision.Wed, Oct 30, 01:04

emack added a subscriber: emack.

emack added inline comments.

cashtab/src/components/Agora/index.js
109	does this mean you still have to maintain the local blacklist and keep it in sync with the server?

This revision now requires changes to proceed.Wed, Oct 30, 01:04

bytesofman requested review of this revision.Wed, Oct 30, 01:06

bytesofman marked an inline comment as done.

bytesofman added inline comments.

cashtab/src/components/Agora/index.js
109	no, though it's an option. I don't think we should not render the agora page if there is some error with token-server So, falling back to a limited (or no blacklist) is the behavior targeted. going forward we could do something like populate the backup cashtab blacklist from the server at buildtime. So the logic is nice to keep.