Page MenuHomePhabricator

[Cashtab] Use token-server blacklist for agora
ClosedPublic

Authored by bytesofman on Oct 29 2024, 14:04.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Commits
rABC831ef47d5ffc: [Cashtab] Use token-server blacklist for agora
Summary

We have a database blacklist live now that we can update without submitting diffs. Use that.

Fall back to local blacklist on error.

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emack requested changes to this revision.Oct 30 2024, 01:04
emack added a subscriber: emack.
emack added inline comments.
cashtab/src/components/Agora/index.js
109 ↗(On Diff #50525)

does this mean you still have to maintain the local blacklist and keep it in sync with the server?

This revision now requires changes to proceed.Oct 30 2024, 01:04
bytesofman marked an inline comment as done.
bytesofman added inline comments.
cashtab/src/components/Agora/index.js
109 ↗(On Diff #50525)

no, though it's an option.

I don't think we should not render the agora page if there is some error with token-server

So, falling back to a limited (or no blacklist) is the behavior targeted.

going forward we could do something like populate the backup cashtab blacklist from the server at buildtime. So the logic is nice to keep.

This revision is now accepted and ready to land.Oct 30 2024, 01:37
This revision was automatically updated to reflect the committed changes.
bytesofman marked an inline comment as done.