Page MenuHomePhabricator

[ecash-herald] Patch axios syntax bug in getNextStakingReward
ClosedPublic

Authored by bytesofman on Fri, Nov 1, 12:56.

Details

Summary

Axios reply returns expected shape in data. We check this, but then get {address, scriptHex} from the raw response and not the data --- so we can never get it.

Test Plan

I created a script and checked the console.log to confirm. We could test this function, but we need to test the mock cache and some other things. I found this while converting herald to typescript, imo the test can wait for that conversion.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
herald-patch
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 30955
Build 61413: Build Diffecash-herald-tests
Build 61412: arc lint + arc unit