Page MenuHomePhabricator

[ecash-herald + token-server] Update typescript and docker build settings
ClosedPublic

Authored by bytesofman on Sun, Nov 3, 12:41.

Details

Summary

These apps are on a similar stack and seeing similar failures in CI.

I am not sure about the ecash-lib build related failure they are both now seeing in CI, but, since it happened after both added the "exclude: node_modules/" setting, I am removing this. Typescript does this by default, potentially it is interfering with other dependencies.

Add tsconfig.build.json so that we do not build the test files.

ecash-herald needs mock-chronik-client as this is used in scripts. Maybe we do not need to build scripts but they could be useful on the server.

Test Plan

docker build -f ecash-herald.Dockerfile -t ecash-herald_local .
docker build -f token-server.Dockerfile -t token-server_local .

local builds pass, but I have not managed to repeat the failure currently seen in CI

Diff Detail

Repository
rABC Bitcoin ABC
Branch
token-server-build-patch
Lint
Lint Passed
SeverityLocationCodeMessage
Auto-Fixapps/ecash-herald/tsconfig.build.json:3WHITESPACE1Found trailing whitespace(s).
Auto-Fixapps/token-server/tsconfig.build.json:3WHITESPACE1Found trailing whitespace(s).
Unit
No Test Coverage
Build Status
Buildable 30978
Build 61459: Build Difftoken-server-tests · ecash-herald-tests
Build 61458: arc lint + arc unit

Event Timeline

bytesofman retitled this revision from [token-server] Update typescript build settings for ecash-herald and token-server to [ecash-herald + token-server] Update typescript and docker build settings.Sun, Nov 3, 12:44
bytesofman edited the test plan for this revision. (Show Details)
bytesofman published this revision for review.Sun, Nov 3, 12:53
emack added a subscriber: emack.
emack added inline comments.
apps/token-server/tsconfig.json
10 ↗(On Diff #50631)

Based on what I've read, setting this flag to true normally fixes this issue for a lot of people online, but you already have it set to true.

This revision is now accepted and ready to land.Mon, Nov 4, 00:51