Page MenuHomePhabricator

[avalanche] Fix the getavaaddr functional test
ClosedPublic

Authored by Fabien on Mon, Nov 4, 21:08.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABC7a0c2cf9ec4a: [avalanche] Fix the getavaaddr functional test
Summary

The interval test is not testing what it expects because it checks for receipt of address twice, but:

  • the reception list is not cleared in between
  • there should be no addr message because there is no new addr to send
  • the getavaaddr message might even not be processed (yet) when the test assumes it is

This diff fixes these issues and check no extra message is sent.

Test Plan
./test/functional/test_runner.py abc_p2p_getavaaddr

Diff Detail

Repository
rABC Bitcoin ABC
Branch
fix_getavaaddr_test
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 30993
Build 61489: Build Diffbuild-without-wallet · build-diff · build-clang-tidy · build-debug · build-clang
Build 61488: arc lint + arc unit