[ecash-herald] Patch typo in secrets.sample.ts
ClosedPublic
Actions

Authored by bytesofman on Wed, Nov 6, 18:04.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC5cdb30488b75: [ecash-herald] Patch typo in secrets.sample.ts

Summary

We want to export the object, not the type

Test Plan

cp secrets.sample.ts secrets.ts

update with values
node scripts/sendMsgByBlock and it works rather than throws type error

This error was not propagated in CI so it only impacts someone trying to run locally by following README instructions, or myself after accidentally deleting secrets.ts

Diff Detail

Repository

rABC Bitcoin ABC

Branch

herald-secrets-patch

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 31037
Build 61577: Build Diff	ecash-herald-tests
Build 61576: arc lint + arc unit

Event Timeline

bytesofman created this revision.Wed, Nov 6, 18:04

Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Nov 6, 18:04

Harbormaster completed remote builds in B31037: Diff 50710.Wed, Nov 6, 18:06

bytesofman published this revision for review.Wed, Nov 6, 18:09

PiRK accepted this revision.Wed, Nov 6, 20:15

This revision is now accepted and ready to land.Wed, Nov 6, 20:15

Closed by commit rABC5cdb30488b75: [ecash-herald] Patch typo in secrets.sample.ts (authored by bytesofman). · Explain WhyWed, Nov 6, 21:35

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABC5cdb30488b75: [ecash-herald] Patch typo in secrets.sample.ts.

Revision Contents
Changeset List

Path

Size

apps/

ecash-herald/

secrets.sample.ts

2 lines

Diff 50710

View Options

apps/ecash-herald/secrets.sample.ts

[ecash-herald] Patch typo in secrets.sample.tsClosedPublicActions