Paths

Table of Contentst

Differential D17091

[Cashtab] Upgrade slpv1 methods to ts
AbandonedPublic
Actions

Authored by bytesofman on Wed, Nov 6, 19:07.

Details

Reviewers

emack

Group Reviewers

Restricted Project

Summary

Depends on D17081

Have a request to add minting more collection inputs, should get slpv1 methods to ts before adding more methods

Do it

Test Plan

npm test

Diff Detail

Repository

rABC Bitcoin ABC

Branch

slpv1-ts-on-wallet

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 31063
Build 61627: Build Diff	cashtab-tests
Build 61626: arc lint + arc unit

Event Timeline

bytesofman created this revision.Wed, Nov 6, 19:07

Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Nov 6, 19:07

Harbormaster completed remote builds in B31039: Diff 50712.Wed, Nov 6, 19:10

bytesofman published this revision for review.Wed, Nov 6, 21:42

bytesofman added a child revision: D17097: [Cashtab] Support minting additional NFT Parent tokens.Thu, Nov 7, 04:34

emack requested changes to this revision.Thu, Nov 7, 10:34

emack added a subscriber: emack.

emack added inline comments.

cashtab/src/slpv1/index.ts
62 ↗	(On Diff #50712)	I may have missed the diff that set this precedence, but we're not enforcing either type for initial supply?
108 ↗	(On Diff #50712)

This revision now requires changes to proceed.Thu, Nov 7, 10:34

just bigint for genesis supply, typo fix

Harbormaster completed remote builds in B31057: Diff 50738.Thu, Nov 7, 14:15

bytesofman marked an inline comment as done.Thu, Nov 7, 14:15

bytesofman added inline comments.

cashtab/src/slpv1/index.ts
62 ↗	(On Diff #50712)	hm looking into it, should be bigint, is only called with bigint in Cashtab. `number` was from pre-ecash-lib days, good catch.

Build aint healthy

This revision now requires changes to proceed.Fri, Nov 8, 03:32

rebase

Harbormaster completed remote builds in B31063: Diff 50747.Fri, Nov 8, 03:57

bytesofman mentioned this in D17100: [Cashtab] slpv1 to ts.Fri, Nov 8, 04:07

superseded by D17100 after some kind of rebase crisis

Harbormaster completed remote builds in B31064: Diff 50748.Fri, Nov 8, 04:49

bytesofman mentioned this in rABC35ce75a0c0dd: [Cashtab] slpv1 to ts.Fri, Nov 8, 12:21

Revision Contents
Changeset List

Path

Size

cashtab/

src/

slpv1/

index.js

wallet/

index.ts

7 lines

Diff 50747

View Options

cashtab/src/slpv1/index.js