Page MenuHomePhabricator

[Cashtab] Upgrade slpv1 methods to ts
AbandonedPublic

Authored by bytesofman on Nov 6 2024, 19:07.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Summary

Depends on D17081

Have a request to add minting more collection inputs, should get slpv1 methods to ts before adding more methods

Do it

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
slpv1-ts-on-wallet
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 31063
Build 61627: Build Diffcashtab-tests
Build 61626: arc lint + arc unit

Event Timeline

bytesofman published this revision for review.Nov 6 2024, 21:42
emack requested changes to this revision.Nov 7 2024, 10:34
emack added a subscriber: emack.
emack added inline comments.
cashtab/src/slpv1/index.ts
62 ↗(On Diff #50712)

I may have missed the diff that set this precedence, but we're not enforcing either type for initial supply?

108 ↗(On Diff #50712)
This revision now requires changes to proceed.Nov 7 2024, 10:34
bytesofman marked an inline comment as done.

just bigint for genesis supply, typo fix

bytesofman added inline comments.
cashtab/src/slpv1/index.ts
62 ↗(On Diff #50712)

hm looking into it, should be bigint, is only called with bigint in Cashtab. number was from pre-ecash-lib days, good catch.

emack requested changes to this revision.Nov 8 2024, 03:32

Build aint healthy

This revision now requires changes to proceed.Nov 8 2024, 03:32

superseded by D17100 after some kind of rebase crisis