Page MenuHomePhabricator

[ecash-herald] Lint for typescript
ClosedPublic

Authored by bytesofman on Nov 12 2024, 19:06.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Commits
rABC4bc82ca4a111: [ecash-herald] Lint for typescript
Summary

ecash-herald ts implementation was in one go. Missed some linting as still getting familiar with ts linting and its settings.

changes are not significant though they can appear that way. Ordering of functions was moved around due to "no use before defined" rule. A few uses of "any" are supported with "expect error" comments as they related to over-complicated types related to functions developed before the ts implementation. Working them out is imo low impact and can wait until these functions are improved.

Test Plan

eslint . and no output; npm test and nothing broke

Diff Detail

Repository
rABC Bitcoin ABC
Branch
herald-unknown-apps
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 31102
Build 61705: Build Diffecash-herald-tests
Build 61704: arc lint + arc unit