Per title.
We want to add more features to OrderBook -- esp websocket so that lists/buys/sells happen in real time. Should convert to ts before expanding features.
Details
Details
- Reviewers
emack - Group Reviewers
Restricted Project - Commits
- rABC92e37d388268: [Cashtab] Convert OrderBook component to ts as prep for adding websocket support
npm test
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- show-agora-listings-on-list
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 31175 Build 61850: Build Diff cashtab-tests Build 61849: arc lint + arc unit
Event Timeline
Comment Actions
Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.
Tail of the build log:
run `npm fund` for details 1 moderate severity vulnerability To address all issues, run: npm audit fix Run `npm audit` for details. > ecash-lib@0.2.1 build > tsc && tsc -p ./tsconfig.build.json && cp -r ./src/ffi ./dist Installing ecash-agora dependencies... /work/modules/ecash-agora /work/modules/ecash-lib /work/modules/ecash-lib-wasm /work/modules/ecash-script /work/modules/chronik-client /work/modules/mock-chronik-client /work/modules/ecashaddrjs /work/abc-ci-builds/cashtab-tests added 364 packages, and audited 367 packages in 2s 60 packages are looking for funding run `npm fund` for details 1 moderate severity vulnerability To address all issues, run: npm audit fix Run `npm audit` for details. > ecash-agora@0.1.1 build > tsc && tsc -p ./tsconfig.build.json /work/cashtab /work/modules/ecash-agora /work/modules/ecash-lib /work/modules/ecash-lib-wasm /work/modules/ecash-script /work/modules/chronik-client /work/modules/mock-chronik-client /work/modules/ecashaddrjs /work/abc-ci-builds/cashtab-tests added 1483 packages, and audited 3329 packages in 24s 323 packages are looking for funding run `npm fund` for details 3 vulnerabilities (2 moderate, 1 high) To address all issues, run: npm audit fix Run `npm audit` for details. > cashtab@2.54.0 build > node scripts/build.js Creating an optimized production build... Treating warnings as errors because process.env.CI = true. Most CI servers set it automatically. Failed to compile. [eslint] src/components/Agora/OrderBook/styled.ts Line 8:10: 'number' is defined but never used @typescript-eslint/no-unused-vars Build cashtab-tests failed with exit code 1