[avalanche] Return pending stake contender status when there is no local staking rewards computed
ClosedPublic
Actions

Authored by roqqit on Nov 15 2024, 18:11.

Details

Reviewers

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rABCea1205ddb23a: [avalanche] Return pending stake contender status when there is no local…

Summary

Before staking rewards is computed on the local node, we cannot be sure
of our vote on any particular contender. To avoid convergence issues, we
respond with a pending status.

This also makes contender voting slightly more robust in the unexpected event
that staking rewards fails to be computed for a block due to a bug or
otherwise.

Test Plan

ninja check-avalanche

Diff Detail

Repository

rABC Bitcoin ABC

Branch

sw-beforefinalblock

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 31196
Build 61892: Build Diff	build-diff · lint-circular-dependencies · build-without-wallet · build-debug · build-clang · build-clang-tidy
Build 61891: arc lint + arc unit

Event Timeline

roqqit created this revision.Nov 15 2024, 18:11

Owners added a reviewer: Restricted Owners Package.Nov 15 2024, 18:11

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 15 2024, 18:11

roqqit requested review of this revision.Nov 15 2024, 18:11

roqqit mentioned this in D17121: [avalanche] Add stake contender polling.Nov 15 2024, 18:13

roqqit added a child revision: D17121: [avalanche] Add stake contender polling.Nov 15 2024, 18:14

Fabien requested changes to this revision.Nov 15 2024, 18:14

Fabien added a subscriber: Fabien.

Fabien added inline comments.

src/avalanche/test/processor_tests.cpp
2521 ↗	(On Diff #50874)	You no longer have an invalid case in this test, it's worth adding it (either here or in a separate diff)

This revision now requires changes to proceed.Nov 15 2024, 18:14

Harbormaster completed remote builds in B31153: Diff 50874.Nov 15 2024, 18:36

Added back an invalid case. It is incomplete since the local winner does not actually trigger an ACCEPT vote, but this should make it more obvious where that test is heading.

Harbormaster completed remote builds in B31196: Diff 50941.Nov 18 2024, 19:12

Fabien accepted this revision.Nov 18 2024, 19:34

Fabien added inline comments.