is_final determines whether or not a block is final, and returns a bool dependant on outcome
Details
Details
- Reviewers
Fabien tobias_ruck - Group Reviewers
Restricted Owners Package (Owns No Changed Paths) Restricted Project - Commits
- rABC8f49415dbac4: [CHRONIK] add is_final to tx struct in util.rs
ninja check-functional
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- adding-is_final-to-tx
- Lint
Lint Errors Severity Location Code Message Error test/functional/chronik_avalanche.py:161 E265 flake8 E265 Error test/functional/chronik_avalanche.py:167 E265 flake8 E265 Error test/functional/chronik_avalanche.py:168 E265 flake8 E265 Warning test/functional/chronik_avalanche.py:120 W291 flake8 W291 Warning test/functional/chronik_avalanche.py:160 W293 flake8 W293 Warning test/functional/chronik_avalanche.py:168 W292 flake8 W292 Auto-Fix test/functional/chronik_avalanche.py:1 FLYNT Converting into f-strings - Unit
No Test Coverage - Build Status
Event Timeline
Comment Actions
When you add a new feature like this you need to also add a test for the new feature so you demonstrate that it works as expected.
You can look at the functional tests in test/functional/chronik_*.py for test examples, and most likely you can extend one of the existing test instead of creating a new one.
| chronik/chronik-indexer/src/query/util.rs | ||
|---|---|---|
| 167 ↗ | (On Diff #50912) | Note that this will not be enough for pre-consensus and will need to be reworked at some point. Not blocking though, this is still an improvement over no flag at all. |
| chronik/chronik-proto/proto/chronik.proto | ||
| 110 ↗ | (On Diff #50912) | The fact that this relates to the block for now is an implementation detail. After pre-consensus this will no longer be the case, but the field can remain and still means the tx is final. |
This comment was removed by hazzarust.