Details

Reviewers

Fabien
tobias_ruck

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rABC8f49415dbac4: [CHRONIK] add is_final to tx struct in util.rs

Summary

is_final determines whether or not a block is final, and returns a bool dependant on outcome

Test Plan

ninja check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Branch

adding-is_final-to-tx

Lint

Lint Errors

Severity	Location	Code	Message
Error	test/functional/chronik_avalanche.py:161	E265	flake8 E265
Error	test/functional/chronik_avalanche.py:167	E265	flake8 E265
Error	test/functional/chronik_avalanche.py:168	E265	flake8 E265
Warning	test/functional/chronik_avalanche.py:120	W291	flake8 W291
Warning	test/functional/chronik_avalanche.py:160	W293	flake8 W293
Warning	test/functional/chronik_avalanche.py:168	W292	flake8 W292
Auto-Fix	test/functional/chronik_avalanche.py:1	FLYNT	Converting into f-strings

Unit

No Test Coverage

Build Status

Buildable 31208
Build 61916: Build Diff	build-clang · build-without-wallet · chronik-client-integration-tests · ecash-lib-integration-tests · ecash-agora-integration-tests · build-diff · build-debug · build-clang-tidy · build-chronik-plugins · build-chronik
Build 61915: arc lint + arc unit

Event Timeline

hazzarust created this revision.Sun, Nov 17, 20:35

Owners added a reviewer: Restricted Owners Package.Sun, Nov 17, 20:35

Herald added a reviewer: Restricted Project. · View Herald TranscriptSun, Nov 17, 20:35

hazzarust requested review of this revision.Sun, Nov 17, 20:35

Harbormaster completed remote builds in B31178: Diff 50911.Sun, Nov 17, 21:00

renamed variable from x to block

Harbormaster completed remote builds in B31179: Diff 50912.Sun, Nov 17, 21:54

When you add a new feature like this you need to also add a test for the new feature so you demonstrate that it works as expected.
You can look at the functional tests in test/functional/chronik_*.py for test examples, and most likely you can extend one of the existing test instead of creating a new one.

chronik/chronik-indexer/src/query/util.rs
167 ↗	(On Diff #50912)	Note that this will not be enough for pre-consensus and will need to be reworked at some point. Not blocking though, this is still an improvement over no flag at all.
chronik/chronik-proto/proto/chronik.proto
110 ↗	(On Diff #50912)	The fact that this relates to the block for now is an implementation detail. After pre-consensus this will no longer be the case, but the field can remain and still means the tx is final.