Page MenuHomePhabricator
Differential D17215

[ecash-lib] Install deps from npm before publishing
ClosedPublic
Actions

Authored by bytesofman on Wed, Nov 27, 18:41.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABC91086accbcc2: [ecash-lib] Install deps from npm before publishing
Summary

This follows the same approach used for chronik-client. Installers of the published npm module ecash-lib cannot get its required dependencies from the monorepo in the same way that abc monorepo apps can.

So, before we publish, we replace the local deps with the latest published deps.

Test Plan

docker build -f ecash-lib.Dockerfile -t ecash-lib_local . builds

Diff Detail

Repository
rABC Bitcoin ABC
Branch
ecash-lib-publish-with-npm-deps
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 31352
Build 62202: Build Diff
Build 62201: arc lint + arc unit

Event Timeline

bytesofman created this revision.Wed, Nov 27, 18:41
Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Nov 27, 18:41
Harbormaster completed remote builds in B31352: Diff 51143.Wed, Nov 27, 18:41
bytesofman published this revision for review.Wed, Nov 27, 18:42
bytesofman added inline comments.
ecash-lib.Dockerfile
6

the uppercase switch is from a lint rule in docker files that must be newer than this file

PiRK accepted this revision.Thu, Nov 28, 15:24
This revision is now accepted and ready to land.Thu, Nov 28, 15:24
Closed by commit rABC91086accbcc2: [ecash-lib] Install deps from npm before publishing (authored by bytesofman). · Explain WhyThu, Nov 28, 16:35
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABC91086accbcc2: [ecash-lib] Install deps from npm before publishing.

Revision Contents
Changeset List

PathSize
24 lines

Diff 51143

View Options

ecash-lib.Dockerfile

Loading...