Page MenuHomePhabricator
Differential D17240

[Cashtab] Do not show ALP and SLP options for NFT mints
ClosedPublic
Actions

Authored by bytesofman on Thu, Nov 28, 23:04.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Commits
rABCe14800143f01: [Cashtab] Do not show ALP and SLP options for NFT mints
Summary

Only SLP NFTs are supported, so do not show this switch for minting NFTs.

Test Plan

npm test, see before and after screenshots

before

image.png (604×1 px, 79 KB)

after

image.png (604×1 px, 87 KB)

Diff Detail

Repository
rABC Bitcoin ABC
Branch
nft-mint-no-alp
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 31389
Build 62276: Build Diffcashtab-tests
Build 62275: arc lint + arc unit

Event Timeline

bytesofman created this revision.Thu, Nov 28, 23:04
Herald added a reviewer: Restricted Project. · View Herald TranscriptThu, Nov 28, 23:04
Harbormaster completed remote builds in B31389: Diff 51194.Thu, Nov 28, 23:08
bytesofman published this revision for review.Thu, Nov 28, 23:15
bytesofman edited the test plan for this revision. (Show Details)
bytesofman added a child revision: D17241: [Cashtab] Update style element to match redesign.Thu, Nov 28, 23:19
emack requested changes to this revision.Fri, Nov 29, 10:30
emack added a subscriber: emack.

In these situations I feel it may be more intuitive if you leave the toggle there but simply disable it (maybe greyed out to indicate lock status?) so that it's clear to the user this is SLP only. Otherwise they might be looking for the toggle they saw previously with no on screen hint as to why it's not there.

This revision now requires changes to proceed.Fri, Nov 29, 10:30
bytesofman requested review of this revision.Fri, Nov 29, 13:48
In D17240#391437, @emack wrote:

In these situations I feel it may be more intuitive if you leave the toggle there but simply disable it (maybe greyed out to indicate lock status?) so that it's clear to the user this is SLP only. Otherwise they might be looking for the toggle they saw previously with no on screen hint as to why it's not there.

in this case, the screen only appears when the user is minting SLP1 NFTs. So there is no option. imo better to show no option. Esp as we add more token types, having 5 disabled switches for token type when the app already knows the token type is ... a bit much imo.

The screen only appears in this way on the Token screen for the NFT. So, both Create Token screens still have the switches.

emack accepted this revision.Sat, Nov 30, 10:22
This revision is now accepted and ready to land.Sat, Nov 30, 10:22
Closed by commit rABCe14800143f01: [Cashtab] Do not show ALP and SLP options for NFT mints (authored by bytesofman). · Explain WhySat, Nov 30, 12:41
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABCe14800143f01: [Cashtab] Do not show ALP and SLP options for NFT mints.

Revision Contents
Changeset List

PathSize
cashtab/
src/
components/
Etokens/
CreateTokenForm/
92 lines

Diff 51194

View Options

cashtab/src/components/Etokens/CreateTokenForm/index.tsx

Loading...