[Cashtab] Standardize mnemonic validation error msg
ClosedPublic
Actions

Authored by bytesofman on Tue, Dec 3, 04:35.

Details

Reviewers

emack

Group Reviewers

Restricted Project

Commits

rABCd5727369b286: [Cashtab] Standardize mnemonic validation error msg

Summary

Some mobile devices can capitalize the first word of a seed when it is typed in.

We prevented this with "type="email"" before but lost that when we upgraded the inputs.

Restore the prevention and improve the validation phrase.

Test Plan

npm test

Diff Detail

Repository

rABC Bitcoin ABC

Branch

cashtab-better-validation-import

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 31491
Build 62479: Build Diff	cashtab-tests
Build 62478: arc lint + arc unit

Event Timeline

bytesofman created this revision.Tue, Dec 3, 04:35

Herald added a reviewer: Restricted Project. · View Herald TranscriptTue, Dec 3, 04:35

Harbormaster completed remote builds in B31489: Diff 51349.Tue, Dec 3, 04:54

bytesofman published this revision for review.Tue, Dec 3, 04:55

add missed type fix

Harbormaster completed remote builds in B31491: Diff 51351.Tue, Dec 3, 05:16

Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.

Tail of the build log:

To address all issues, run:
  npm audit fix

Run `npm audit` for details.

> ecash-lib@1.1.0 build
> tsc && tsc -p ./tsconfig.build.json && cp -r ./src/ffi ./dist

Installing ecash-agora dependencies...
/work/modules/ecash-agora /work/modules/ecash-lib /work/modules/ecash-lib-wasm /work/modules/ecash-script /work/modules/chronik-client /work/modules/mock-chronik-client /work/modules/ecashaddrjs /work/abc-ci-builds/cashtab-tests

added 364 packages, and audited 367 packages in 1s

60 packages are looking for funding
  run `npm fund` for details

2 vulnerabilities (1 moderate, 1 high)

To address all issues, run:
  npm audit fix

Run `npm audit` for details.

> ecash-agora@0.2.0 build
> tsc && tsc -p ./tsconfig.build.json

/work/cashtab /work/modules/ecash-agora /work/modules/ecash-lib /work/modules/ecash-lib-wasm /work/modules/ecash-script /work/modules/chronik-client /work/modules/mock-chronik-client /work/modules/ecashaddrjs /work/abc-ci-builds/cashtab-tests
npm warn deprecated @humanwhocodes/config-array@0.11.14: Use @eslint/config-array instead
npm warn deprecated @humanwhocodes/object-schema@2.0.3: Use @eslint/object-schema instead
npm warn deprecated eslint@8.56.0: This version is no longer supported. Please see https://eslint.org/version-support for other options.

added 1487 packages, and audited 3333 packages in 24s

323 packages are looking for funding
  run `npm fund` for details

4 vulnerabilities (2 moderate, 2 high)

To address all issues, run:
  npm audit fix

Run `npm audit` for details.

> cashtab@3.2.2 build
> node scripts/build.js

Creating an optimized production build...
Failed to compile.

TS2741: Property 'type' is missing in type '{ placeholder: string; name: string; value: string; error: string | false; handleInput: (e: ChangeEvent<HTMLInputElement>) => void; }' but required in type 'ModalInputProps'.
  [0m [90m 2055 |[39m                             height[33m=[39m{[35m250[39m}
   [90m 2056 |[39m                         [33m>[39m
  [31m[1m>[22m[39m[90m 2057 |[39m                             [33m<[39m[33mModalInput[39m
   [90m      |[39m                              [31m[1m^[22m[39m[31m[1m^[22m[39m[31m[1m^[22m[39m[31m[1m^[22m[39m[31m[1m^[22m[39m[31m[1m^[22m[39m[31m[1m^[22m[39m[31m[1m^[22m[39m[31m[1m^[22m[39m[31m[1m^[22m[39m
   [90m 2058 |[39m                                 placeholder[33m=[39m{[32m`Type "burn ${tokenTicker}" to confirm`[39m}
   [90m 2059 |[39m                                 name[33m=[39m[32m"etokenToBeBurnt"[39m
   [90m 2060 |[39m                                 value[33m=[39m{confirmationOfEtokenToBeBurnt}[0m


Build cashtab-tests failed with exit code 1

patch type def

Harbormaster completed remote builds in B31493: Diff 51353.Tue, Dec 3, 05:24

emack accepted this revision.Tue, Dec 3, 07:32

This revision is now accepted and ready to land.Tue, Dec 3, 07:32

Closed by commit rABCd5727369b286: [Cashtab] Standardize mnemonic validation error msg (authored by bytesofman). · Explain WhyTue, Dec 3, 14:08

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABCd5727369b286: [Cashtab] Standardize mnemonic validation error msg.