[Cashtab] Convert wallet context to ts
DraftPublic
Actions

Authored by bytesofman on Tue, Dec 3, 21:11.

Details

Reviewers

None

Group Reviewers

Restricted Project

Summary

Troubleshooting load speed issues in Cashtab. Need to get typescript at the highest level so I can find any mismatches. Start here.

Test Plan

npm test, arc lint no ts errors

Diff Detail

Repository

rABC Bitcoin ABC

Branch

wallet-context-to-ts

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 31511
Build 62519: Build Diff	cashtab-tests
Build 62518: arc lint + arc unit

Event Timeline

bytesofman created this revision.Tue, Dec 3, 21:11

Herald added a reviewer: Restricted Project. · View Herald TranscriptTue, Dec 3, 21:11

Harbormaster completed remote builds in B31510: Diff 51386.Tue, Dec 3, 21:14

Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.

Tail of the build log:

To address all issues, run:
  npm audit fix

Run `npm audit` for details.

> ecash-lib@1.1.0 build
> tsc && tsc -p ./tsconfig.build.json && cp -r ./src/ffi ./dist

Installing ecash-agora dependencies...
/work/modules/ecash-agora /work/modules/ecash-lib /work/modules/ecash-lib-wasm /work/modules/ecash-script /work/modules/chronik-client /work/modules/mock-chronik-client /work/modules/ecashaddrjs /work/abc-ci-builds/cashtab-tests

added 364 packages, and audited 367 packages in 2s

60 packages are looking for funding
  run `npm fund` for details

2 vulnerabilities (1 moderate, 1 high)

To address all issues, run:
  npm audit fix

Run `npm audit` for details.

> ecash-agora@0.2.0 build
> tsc && tsc -p ./tsconfig.build.json

/work/cashtab /work/modules/ecash-agora /work/modules/ecash-lib /work/modules/ecash-lib-wasm /work/modules/ecash-script /work/modules/chronik-client /work/modules/mock-chronik-client /work/modules/ecashaddrjs /work/abc-ci-builds/cashtab-tests
npm warn deprecated @humanwhocodes/config-array@0.11.14: Use @eslint/config-array instead
npm warn deprecated @humanwhocodes/object-schema@2.0.3: Use @eslint/object-schema instead
npm warn deprecated eslint@8.56.0: This version is no longer supported. Please see https://eslint.org/version-support for other options.

added 1487 packages, and audited 3333 packages in 1m

323 packages are looking for funding
  run `npm fund` for details

4 vulnerabilities (2 moderate, 2 high)

To address all issues, run:
  npm audit fix

Run `npm audit` for details.

> cashtab@3.2.4 build
> node scripts/build.js

Creating an optimized production build...
Failed to compile.

TS2339: Property 'ecc' does not exist on type 'UseWalletReturnType | null'.
  [0m [90m 33 |[39m     [36mconst[39m [33mContextValue[39m [33m=[39m [33mReact[39m[33m.[39museContext([33mWalletContext[39m)[33m;[39m
   [90m 34 |[39m     [36mconst[39m {
  [31m[1m>[22m[39m[90m 35 |[39m         ecc[33m,[39m
   [90m    |[39m         [31m[1m^[22m[39m[31m[1m^[22m[39m[31m[1m^[22m[39m
   [90m 36 |[39m         fiatPrice[33m,[39m
   [90m 37 |[39m         chronik[33m,[39m
   [90m 38 |[39m         agora[33m,[39m[0m


Build cashtab-tests failed with exit code 1

more ts conversions, now need to handle undefined in context

Harbormaster completed remote builds in B31511: Diff 51387.Tue, Dec 3, 23:05

Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.

Tail of the build log:

To address all issues, run:
  npm audit fix

Run `npm audit` for details.

> ecash-lib@1.1.0 build
> tsc && tsc -p ./tsconfig.build.json && cp -r ./src/ffi ./dist

Installing ecash-agora dependencies...
/work/modules/ecash-agora /work/modules/ecash-lib /work/modules/ecash-lib-wasm /work/modules/ecash-script /work/modules/chronik-client /work/modules/mock-chronik-client /work/modules/ecashaddrjs /work/abc-ci-builds/cashtab-tests

added 364 packages, and audited 367 packages in 2s

60 packages are looking for funding
  run `npm fund` for details

2 vulnerabilities (1 moderate, 1 high)

To address all issues, run:
  npm audit fix

Run `npm audit` for details.

> ecash-agora@0.2.0 build
> tsc && tsc -p ./tsconfig.build.json

/work/cashtab /work/modules/ecash-agora /work/modules/ecash-lib /work/modules/ecash-lib-wasm /work/modules/ecash-script /work/modules/chronik-client /work/modules/mock-chronik-client /work/modules/ecashaddrjs /work/abc-ci-builds/cashtab-tests
npm warn deprecated @humanwhocodes/config-array@0.11.14: Use @eslint/config-array instead
npm warn deprecated @humanwhocodes/object-schema@2.0.3: Use @eslint/object-schema instead
npm warn deprecated eslint@8.56.0: This version is no longer supported. Please see https://eslint.org/version-support for other options.

added 1489 packages, and audited 3335 packages in 25s

323 packages are looking for funding
  run `npm fund` for details

4 vulnerabilities (2 moderate, 2 high)

To address all issues, run:
  npm audit fix

Run `npm audit` for details.

> cashtab@3.2.4 build
> node scripts/build.js

Creating an optimized production build...
Failed to compile.

TS2339: Property 'wallets' does not exist on type 'CashtabState | undefined'.
  [0m [90m 41 |[39m         chaintipBlockheight[33m,[39m
   [90m 42 |[39m     } [33m=[39m [33mContextValue[39m[33m;[39m
  [31m[1m>[22m[39m[90m 43 |[39m     [36mconst[39m { wallets[33m,[39m settings[33m,[39m cashtabCache } [33m=[39m cashtabState[33m;[39m
   [90m    |[39m             [31m[1m^[22m[39m[31m[1m^[22m[39m[31m[1m^[22m[39m[31m[1m^[22m[39m[31m[1m^[22m[39m[31m[1m^[22m[39m[31m[1m^[22m[39m
   [90m 44 |[39m     [36mconst[39m wallet [33m=[39m wallets[33m.[39mlength [33m>[39m [35m0[39m [33m?[39m wallets[[35m0[39m] [33m:[39m [36mfalse[39m[33m;[39m
   [90m 45 |[39m     [36mconst[39m pk [33m=[39m
   [90m 46 |[39m         wallet [33m===[39m [36mfalse[39m [33m?[39m [36mnull[39m [33m:[39m wallet[33m.[39mpaths[33m.[39m[36mget[39m(appConfig[33m.[39mderivationPath)[33m.[39mpk[33m;[39m[0m


Build cashtab-tests failed with exit code 1