Differential D17307

[e.cash] Better handle price api response
ClosedPublic
Actions

Authored by johnkuney on Fri, Dec 6, 16:41.

Details

Reviewers

bytesofman

Group Reviewers

Restricted Project

Commits

rABC1601e2b374db: [e.cash] Better handle price api response

Summary

Got a NaN displayed from broken price api.
Adding a check to make sure the price value is a number before setting it

Test Plan

npm run dev

Diff Detail

Repository

rABC Bitcoin ABC

Branch

ecash-fix-price-display

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 31557
Build 62611: Build Diff
Build 62610: arc lint + arc unit

Event Timeline

johnkuney created this revision.Fri, Dec 6, 16:41

Herald added a reviewer: Restricted Project. · View Herald TranscriptFri, Dec 6, 16:41

johnkuney requested review of this revision.Fri, Dec 6, 16:41

Harbormaster completed remote builds in B31557: Diff 51448.Fri, Dec 6, 16:42

bytesofman accepted this revision.Fri, Dec 6, 18:16

This revision is now accepted and ready to land.Fri, Dec 6, 18:16

Closed by commit rABC1601e2b374db: [e.cash] Better handle price api response (authored by johnkuney). · Explain WhyFri, Dec 6, 20:07

This revision was automatically updated to reflect the committed changes.

johnkuney added a commit: rABC1601e2b374db: [e.cash] Better handle price api response.

Revision Contents
Changeset List

Path

Size

web/

e.cash/

components/

navbar/

getNavbarData.js

11 lines

Diff 51448

View Options

web/e.cash/components/navbar/getNavbarData.js

[e.cash] Better handle price api responseClosedPublicActions