Page MenuHomePhabricator

[BITCOIN-ABC CI] Added `cargo build --locked` CI to web/explorer && `explorer.Dockerfile`
ClosedPublic

Authored by hazzarust on Thu, Dec 5, 18:16.

Details

Reviewers
tobias_ruck
Fabien
Group Reviewers
Restricted Project
Restricted Owners Package(Owns No Changed Paths)
Commits
rABC5dbda19390ac: [BITCOIN-ABC CI] Added `cargo build --locked` CI to web/explorer && `explorer.
Summary

Every time there is a change to any file within web/explorer, run cargo build --locked && cargo test

Test Plan

@bot build-explorer python3 contrib/teamcity/build-configurations.py build-explorer @bot preview-explorer

Diff Detail

Repository
rABC Bitcoin ABC
Branch
explorer_ci
Lint
Lint Errors
SeverityLocationCodeMessage
Errorcontrib/teamcity/build-configurations.yml:427trailing-spacesyamllint found an issue:
Unit
No Test Coverage
Build Status
Buildable 31559
Build 62615: Build Diff
Build 62614: arc lint + arc unit

Event Timeline

Owners added a reviewer: Restricted Owners Package.Thu, Dec 5, 18:16
This comment was removed by hazzarust.
hazzarust published this revision for review.Fri, Dec 6, 01:19
hazzarust edited the summary of this revision. (Show Details)
hazzarust removed a reviewer: Restricted Owners Package.
Fabien added inline comments.
contrib/teamcity/build-configurations.yml
360 ↗(On Diff #51431)

Please move it down to keep alpha sorting

The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
tobias_ruck added inline comments.
contrib/teamcity/build-configurations.yml
360 ↗(On Diff #51431)

also bad indent

This revision now requires changes to proceed.Fri, Dec 6, 11:25
hazzarust edited the summary of this revision. (Show Details)

Updated formatting

Owners added a reviewer: Restricted Owners Package.Fri, Dec 6, 17:20

For the test plan, you can run the build on your machine just like it's run on CI:
./contrib/teamcity/build-configurations.py build-explorer
You might need to install some pip packages, just follow what python fails to import.

Fabien requested changes to this revision.Fri, Dec 6, 21:02
Fabien added inline comments.
contrib/teamcity/build-configurations.yml
436 ↗(On Diff #51451)

we should start using cargo build --locked

This revision now requires changes to proceed.Fri, Dec 6, 21:02

Changed cargo build to cargo build --locked to ensure reproducible builds

hazzarust retitled this revision from [BITCOIN-ABC CI] Added `cargo build` CI to web/explorer to [BITCOIN-ABC CI] Added `cargo build --locked` CI to web/explorer.Sat, Dec 7, 16:49
hazzarust edited the summary of this revision. (Show Details)
hazzarust edited the test plan for this revision. (Show Details)

Adding --locked to explorer.Dockerfile as D17313 did not specify cargo build --release --locked

hazzarust retitled this revision from [BITCOIN-ABC CI] Added `cargo build --locked` CI to web/explorer to [BITCOIN-ABC CI] Added `cargo build --locked` CI to web/explorer && `explorer.Dockerfile`.Sun, Dec 8, 03:09
hazzarust edited the test plan for this revision. (Show Details)

Tail of the build log:

   Doc-tests chronik-proto

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests chronik-util

running 2 tests
test chronik/chronik-util/src/log.rs - log::log (line 65) ... ignored
test chronik/chronik-util/src/log.rs - log::log_chronik (line 87) ... ignored

test result: ok. 0 passed; 0 failed; 2 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests ecash-secp256k1

running 25 tests
test modules/ecash-secp256k1/src/context.rs - context::alloc_only::Secp256k1<C>::gen_new (line 199) ... ok
test modules/ecash-secp256k1/src/key.rs - key::SecretKey (line 47) ... ok
test modules/ecash-secp256k1/src/ecdh.rs - ecdh::SharedSecret (line 22) ... ok
test modules/ecash-secp256k1/src/key.rs - key::Keypair (line 881) ... ok
test modules/ecash-secp256k1/src/key.rs - key::PublicKey::combine_keys (line 732) ... ok
test modules/ecash-secp256k1/src/key.rs - key::PublicKey::from_secret_key (line 447) ... ok
test modules/ecash-secp256k1/src/key.rs - key::PublicKey::from_keypair (line 552) ... ok
test modules/ecash-secp256k1/src/ecdh.rs - ecdh::shared_secret_point (line 124) ... ok
test modules/ecash-secp256k1/src/ecdsa/mod.rs - ecdsa::Secp256k1<C>::verify_ecdsa (line 373) ... ok
test modules/ecash-secp256k1/src/key.rs - key::PublicKey::combine (line 702) ... ok
test modules/ecash-secp256k1/src/key.rs - key::Keypair::add_xonly_tweak (line 1045) ... ok
test modules/ecash-secp256k1/src/key.rs - key::PublicKey (line 149) ... ok
test modules/ecash-secp256k1/src/key.rs - key::SecretKey::from_keypair (line 280) ... ok
test modules/ecash-secp256k1/src/key.rs - key::XOnlyPublicKey::add_tweak (line 1405) ... ok
test modules/ecash-secp256k1/src/lib.rs - (line 30) ... ok
test modules/ecash-secp256k1/src/lib.rs - (line 49) ... ok
test modules/ecash-secp256k1/src/key.rs - key::SecretKey::from_byte_array (line 255) ... ok
test modules/ecash-secp256k1/src/key.rs - key::XOnlyPublicKey::tweak_add_check (line 1469) ... ok
test modules/ecash-secp256k1/src/key.rs - key::XOnlyPublicKey (line 1261) ... ok
test modules/ecash-secp256k1/src/key.rs - key::SecretKey::from_slice (line 238) ... ok
test modules/ecash-secp256k1/src/lib.rs - (line 92) ... ok
test modules/ecash-secp256k1/src/secret.rs - secret::Keypair::display_secret (line 139) ... ok
test modules/ecash-secp256k1/src/lib.rs - (line 71) ... ok
test modules/ecash-secp256k1/src/secret.rs - secret::SecretKey::display_secret (line 98) ... ok
test modules/ecash-secp256k1/src/secret.rs - secret::SharedSecret::display_secret (line 180) ... ok

test result: ok. 25 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.54s

   Doc-tests ecash-secp256k1-sys

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests explorer-server

running 1 test
test web/explorer/explorer-server/src/chain.rs - chain::Chain::from_str (line 23) ... ok

test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 2.15s

/work/abc-ci-builds/build-explorer/script.sh: line 9: timeout:: command not found
Build build-explorer failed with exit code 127
Fabien requested changes to this revision.Wed, Dec 11, 08:42

Make sure to run the test plan yourself

contrib/teamcity/build-configurations.yml
438 ↗(On Diff #51483)

There is an indentation issue here

This revision now requires changes to proceed.Wed, Dec 11, 08:42

fixed indentation issue (timeout was indented in script, removed indentation)

This revision is now accepted and ready to land.Wed, Dec 11, 12:05