Paths

Table of Contentst

Differential D17327

Use os.cpu_count in test_runner instead of multiprocessing
ClosedPublic
Actions

Authored by roqqit on Mon, Dec 9, 19:43.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rABCe0198d8be5cd: Use os.cpu_count in test_runner instead of multiprocessing

Summary

This eliminates unnecessarily importing multiprocessing. multiprocessing.cpu_count() just calls os.cpu_count() anyway:
https://github.com/python/cpython/blob/main/Lib/multiprocessing/context.py#L43

The or 1 keeps the linter happy since os.cpu_count() can return None in some rare cases.

Test Plan

ninja check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Branch

test-runner-multiproc

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 31591
Build 62679: Build Diff	build-clang-tidy · build-diff · build-clang · build-without-wallet · build-debug
Build 62678: arc lint + arc unit

Event Timeline

roqqit created this revision.Mon, Dec 9, 19:43

Owners added a reviewer: Restricted Owners Package.Mon, Dec 9, 19:43

Herald added a reviewer: Restricted Project. · View Herald TranscriptMon, Dec 9, 19:43

roqqit requested review of this revision.Mon, Dec 9, 19:43

Harbormaster completed remote builds in B31591: Diff 51505.Mon, Dec 9, 20:01

PiRK accepted this revision.Mon, Dec 9, 20:46

This revision is now accepted and ready to land.Mon, Dec 9, 20:46

Closed by commit rABCe0198d8be5cd: Use os.cpu_count in test_runner instead of multiprocessing (authored by roqqit). · Explain WhyMon, Dec 9, 21:12

This revision was automatically updated to reflect the committed changes.

roqqit added a commit: rABCe0198d8be5cd: Use os.cpu_count in test_runner instead of multiprocessing.

Revision Contents
Changeset List

Path

Size

test/

functional/

3 lines

Diff 51505

test/functional/test_runner.py

Loading...