Differential D17334

[e.cash] Add openInNewTab prop to /use-ecash buttons
ClosedPublic
Actions

Authored by johnkuney on Dec 11 2024, 04:35.

Details

Reviewers

bytesofman

Group Reviewers

Restricted Project

Commits

rABC931c83b45e5a: [e.cash] Add openInNewTab prop to /use-ecash buttons

Summary

Since these are external links they should open in new tabs

Test Plan

preview the site and check the links on /use-ecash open in new tabs

Diff Detail

Repository

rABC Bitcoin ABC

Branch

ecash-external-links

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 31611
Build 62719: Build Diff
Build 62718: arc lint + arc unit

Event Timeline

johnkuney created this revision.Dec 11 2024, 04:35

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 11 2024, 04:35

johnkuney requested review of this revision.Dec 11 2024, 04:35

Harbormaster completed remote builds in B31611: Diff 51532.Dec 11 2024, 04:35

bytesofman accepted this revision.Dec 11 2024, 05:02

This revision is now accepted and ready to land.Dec 11 2024, 05:02

Closed by commit rABC931c83b45e5a: [e.cash] Add openInNewTab prop to /use-ecash buttons (authored by johnkuney). · Explain WhyDec 11 2024, 05:19

This revision was automatically updated to reflect the committed changes.

johnkuney added a commit: rABC931c83b45e5a: [e.cash] Add openInNewTab prop to /use-ecash buttons.

Mengerian mentioned this in D17346: [e.cash] Open external button links in new tabs.Dec 12 2024, 22:19

Mengerian mentioned this in rABCaa32579dd498: [e.cash] Open external button links in new tabs.Dec 13 2024, 18:00

Revision Contents
Changeset List

Path

Size

web/

e.cash/

pages/

use-ecash.js

3 lines

Diff 51532

View Options

web/e.cash/pages/use-ecash.js

[e.cash] Add openInNewTab prop to /use-ecash buttonsClosedPublicActions