[ecash-herald] Correct upgraded mock chronik client in script
ClosedPublic
Actions

Authored by bytesofman on Fri, Dec 13, 23:00.

Details

Reviewers

emack

Group Reviewers

Restricted Project

Commits

rABC83bf5311bb43: [ecash-herald] Correct upgraded mock chronik client in script

Summary

Missed this as the scripts are not directly tested. Builds are failing as typescript lint catches issues here.

Test Plan

CI build, npm run build, npm test, ts-node scripts/generateMocks

Diff Detail

Repository

rABC Bitcoin ABC

Branch

fix-herald-build

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 31647
Build 62791: Build Diff	ecash-herald-tests
Build 62790: arc lint + arc unit

Event Timeline

bytesofman created this revision.Fri, Dec 13, 23:00

Herald added a reviewer: Restricted Project. · View Herald TranscriptFri, Dec 13, 23:00

Harbormaster completed remote builds in B31647: Diff 51582.Fri, Dec 13, 23:02

bytesofman published this revision for review.Fri, Dec 13, 23:36

emack accepted this revision.Sun, Dec 15, 20:42

This revision is now accepted and ready to land.Sun, Dec 15, 20:42

Closed by commit rABC83bf5311bb43: [ecash-herald] Correct upgraded mock chronik client in script (authored by bytesofman). · Explain WhySun, Dec 15, 21:51

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABC83bf5311bb43: [ecash-herald] Correct upgraded mock chronik client in script.

Revision Contents
Changeset List

Path

Size

apps/

ecash-herald/

scripts/

generateMock.ts

41 lines

Diff 51582

View Options

apps/ecash-herald/scripts/generateMock.ts

[ecash-herald] Correct upgraded mock chronik client in scriptClosedPublicActions