Page MenuHomePhabricator
Differential D17340

[Cashtab] Parse tx history async to resolve UI lock issue on homescreen
ClosedPublic
Actions

Authored by bytesofman on Thu, Dec 12, 15:03.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Commits
rABC30a23d5b0dad: [Cashtab] Parse tx history async to resolve UI lock issue on homescreen
Summary

Cashtab has a bug in tx parsing that causes the UI to lock while tx history is rendered. It's especially noticeable on wallets with Agora txs in history.
'
Tx parsing should be done async. The parsed tx should then be passed to the Tx component for rendering.

We have instead been using the Tx component to parse and render txs.

This diff refactors Cashtab tx parsing so that all parsing is handled by the parseTx function, which is called async on each tx. When the history is ready, it is passed to the Tx component for rendering.

The size of the refactor makes this a difficult review. However, now that parsedTx is strongly typed, the logic changes can be deduced from the new type definitions. We preserve all of the rendering tests, which are updated for some differences in parsing (for example, we now parse each tokenEntry insteead of just the first).

Test Plan

npm test

This diff is deployed at the test site https://cashtab-local-dev.netlify.app/#/

Can confirm there that load times are significantly improved for wallets with Agora txs in history.

This diff also fixes the issue of the "menu expand animation goes slow"

night and day performance difference

Diff Detail

Repository
rABC Bitcoin ABC
Branch
unbork-tx-history
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 31672
Build 62840: Build Diffcashtab-tests
Build 62839: arc lint + arc unit

Event Timeline

bytesofman created this revision.Thu, Dec 12, 15:03
Herald added a reviewer: Restricted Project. · View Herald TranscriptThu, Dec 12, 15:03
Harbormaster completed remote builds in B31628: Diff 51554.Thu, Dec 12, 15:03
teamcity added a comment.Thu, Dec 12, 15:07
Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.

Tail of the build log:

Run `npm audit` for details.

> ecash-lib@1.1.0 build
> tsc && tsc -p ./tsconfig.build.json && cp -r ./src/ffi ./dist

Installing ecash-agora dependencies...
/work/modules/ecash-agora /work/modules/ecash-lib /work/modules/ecash-lib-wasm /work/modules/ecash-script /work/modules/chronik-client /work/modules/mock-chronik-client /work/modules/ecashaddrjs /work/abc-ci-builds/cashtab-tests

added 364 packages, and audited 367 packages in 2s

60 packages are looking for funding
  run `npm fund` for details

2 vulnerabilities (1 moderate, 1 high)

To address all issues, run:
  npm audit fix

Run `npm audit` for details.

> ecash-agora@0.2.0 build
> tsc && tsc -p ./tsconfig.build.json

/work/cashtab /work/modules/ecash-agora /work/modules/ecash-lib /work/modules/ecash-lib-wasm /work/modules/ecash-script /work/modules/chronik-client /work/modules/mock-chronik-client /work/modules/ecashaddrjs /work/abc-ci-builds/cashtab-tests
npm warn deprecated @humanwhocodes/config-array@0.11.14: Use @eslint/config-array instead
npm warn deprecated @humanwhocodes/object-schema@2.0.3: Use @eslint/object-schema instead
npm warn deprecated eslint@8.56.0: This version is no longer supported. Please see https://eslint.org/version-support for other options.

added 1489 packages, and audited 3335 packages in 24s

323 packages are looking for funding
  run `npm fund` for details

8 vulnerabilities (2 low, 4 moderate, 2 high)

To address issues that do not require attention, run:
  npm audit fix

To address all issues (including breaking changes), run:
  npm audit fix --force

Run `npm audit` for details.

> cashtab@3.2.12 build
> node scripts/build.js

Creating an optimized production build...
Failed to compile.

TS2739: Type '{ xecTxType: XecTxType.Received; satoshisSent: number; stackArray: string[]; recipients: string[]; }' is missing the following properties from type 'ParsedTx': parsedTokenEntries, appActions
    275 |                 tokenFailedParsings: [],
    276 |                 tokenStatus: 'TOKEN_STATUS_NORMAL',
  > 277 |                 parsed: {
        |                 ^^^^^^
    278 |                     xecTxType: XecTxType.Received,
    279 |                     satoshisSent: 546,
    280 |                     stackArray: [


Build cashtab-tests failed with exit code 1
bytesofman updated this revision to Diff 51571.Fri, Dec 13, 16:24

not a good stopping point but have to do kid stuff

Harbormaster completed remote builds in B31639: Diff 51571.Fri, Dec 13, 16:24
teamcity added a comment.Fri, Dec 13, 16:27
Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.

Tail of the build log:

Run `npm audit` for details.

> ecash-lib@1.1.0 build
> tsc && tsc -p ./tsconfig.build.json && cp -r ./src/ffi ./dist

Installing ecash-agora dependencies...
/work/modules/ecash-agora /work/modules/ecash-lib /work/modules/ecash-lib-wasm /work/modules/ecash-script /work/modules/chronik-client /work/modules/mock-chronik-client /work/modules/ecashaddrjs /work/abc-ci-builds/cashtab-tests

added 364 packages, and audited 367 packages in 2s

60 packages are looking for funding
  run `npm fund` for details

2 vulnerabilities (1 moderate, 1 high)

To address all issues, run:
  npm audit fix

Run `npm audit` for details.

> ecash-agora@0.2.0 build
> tsc && tsc -p ./tsconfig.build.json

/work/cashtab /work/modules/ecash-agora /work/modules/ecash-lib /work/modules/ecash-lib-wasm /work/modules/ecash-script /work/modules/chronik-client /work/modules/mock-chronik-client /work/modules/ecashaddrjs /work/abc-ci-builds/cashtab-tests
npm warn deprecated @humanwhocodes/config-array@0.11.14: Use @eslint/config-array instead
npm warn deprecated @humanwhocodes/object-schema@2.0.3: Use @eslint/object-schema instead
npm warn deprecated eslint@8.56.0: This version is no longer supported. Please see https://eslint.org/version-support for other options.

added 1489 packages, and audited 3335 packages in 25s

323 packages are looking for funding
  run `npm fund` for details

8 vulnerabilities (2 low, 4 moderate, 2 high)

To address issues that do not require attention, run:
  npm audit fix

To address all issues (including breaking changes), run:
  npm audit fix --force

Run `npm audit` for details.

> cashtab@3.2.12 build
> node scripts/build.js

Creating an optimized production build...
Failed to compile.

TS2339: Property 'AgoraSale' does not exist on type 'typeof XecTxType'.
    935 |                 // For sales of agora partial txs, we assume the amount sold
    936 |                 // goes to a p2pkh address
  > 937 |                 if (xecTxType === XecTxType.AgoraSale) {
        |                                             ^^^^^^^^^
    938 |                     const { type } = cashaddr.getTypeAndHashFromOutputScript(
    939 |                         output.outputScript,
    940 |                     );


Build cashtab-tests failed with exit code 1
bytesofman updated this revision to Diff 51583.Fri, Dec 13, 23:56

getting parseTx tests to pass

Harbormaster completed remote builds in B31648: Diff 51583.Fri, Dec 13, 23:56
teamcity added a comment.Fri, Dec 13, 23:59
Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.

Tail of the build log:

Run `npm audit` for details.

> ecash-lib@1.1.0 build
> tsc && tsc -p ./tsconfig.build.json && cp -r ./src/ffi ./dist

Installing ecash-agora dependencies...
/work/modules/ecash-agora /work/modules/ecash-lib /work/modules/ecash-lib-wasm /work/modules/ecash-script /work/modules/chronik-client /work/modules/mock-chronik-client /work/modules/ecashaddrjs /work/abc-ci-builds/cashtab-tests

added 364 packages, and audited 367 packages in 2s

60 packages are looking for funding
  run `npm fund` for details

2 vulnerabilities (1 moderate, 1 high)

To address all issues, run:
  npm audit fix

Run `npm audit` for details.

> ecash-agora@0.2.0 build
> tsc && tsc -p ./tsconfig.build.json

/work/cashtab /work/modules/ecash-agora /work/modules/ecash-lib /work/modules/ecash-lib-wasm /work/modules/ecash-script /work/modules/chronik-client /work/modules/mock-chronik-client /work/modules/ecashaddrjs /work/abc-ci-builds/cashtab-tests
npm warn deprecated @humanwhocodes/config-array@0.11.14: Use @eslint/config-array instead
npm warn deprecated @humanwhocodes/object-schema@2.0.3: Use @eslint/object-schema instead
npm warn deprecated eslint@8.56.0: This version is no longer supported. Please see https://eslint.org/version-support for other options.

added 1489 packages, and audited 3335 packages in 24s

323 packages are looking for funding
  run `npm fund` for details

8 vulnerabilities (2 low, 4 moderate, 2 high)

To address issues that do not require attention, run:
  npm audit fix

To address all issues (including breaking changes), run:
  npm audit fix --force

Run `npm audit` for details.

> cashtab@3.2.12 build
> node scripts/build.js

Creating an optimized production build...
Failed to compile.

TS2739: Type '{ xecTxType: XecTxType.Received; satoshisSent: number; stackArray: string[]; recipients: string[]; }' is missing the following properties from type 'ParsedTx': appActions, parsedTokenEntries
    275 |                 tokenFailedParsings: [],
    276 |                 tokenStatus: 'TOKEN_STATUS_NORMAL',
  > 277 |                 parsed: {
        |                 ^^^^^^
    278 |                     xecTxType: XecTxType.Received,
    279 |                     satoshisSent: 546,
    280 |                     stackArray: [


Build cashtab-tests failed with exit code 1
bytesofman updated this revision to Diff 51595.Sat, Dec 14, 23:04

not a good stopping point but works well in prod without the tx render slowdown problem. Still need more mocks and to get through refactoring the render unit tests

Harbormaster completed remote builds in B31658: Diff 51595.Sat, Dec 14, 23:04
teamcity added a comment.Sat, Dec 14, 23:07
Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.

Tail of the build log:

Run `npm audit` for details.

> ecash-lib@1.1.0 build
> tsc && tsc -p ./tsconfig.build.json && cp -r ./src/ffi ./dist

Installing ecash-agora dependencies...
/work/modules/ecash-agora /work/modules/ecash-lib /work/modules/ecash-lib-wasm /work/modules/ecash-script /work/modules/chronik-client /work/modules/mock-chronik-client /work/modules/ecashaddrjs /work/abc-ci-builds/cashtab-tests

added 364 packages, and audited 367 packages in 2s

60 packages are looking for funding
  run `npm fund` for details

2 vulnerabilities (1 moderate, 1 high)

To address all issues, run:
  npm audit fix

Run `npm audit` for details.

> ecash-agora@0.2.0 build
> tsc && tsc -p ./tsconfig.build.json

/work/cashtab /work/modules/ecash-agora /work/modules/ecash-lib /work/modules/ecash-lib-wasm /work/modules/ecash-script /work/modules/chronik-client /work/modules/mock-chronik-client /work/modules/ecashaddrjs /work/abc-ci-builds/cashtab-tests
npm warn deprecated @humanwhocodes/config-array@0.11.14: Use @eslint/config-array instead
npm warn deprecated @humanwhocodes/object-schema@2.0.3: Use @eslint/object-schema instead
npm warn deprecated eslint@8.56.0: This version is no longer supported. Please see https://eslint.org/version-support for other options.

added 1489 packages, and audited 3335 packages in 25s

323 packages are looking for funding
  run `npm fund` for details

8 vulnerabilities (2 low, 4 moderate, 2 high)

To address issues that do not require attention, run:
  npm audit fix

To address all issues (including breaking changes), run:
  npm audit fix --force

Run `npm audit` for details.

> cashtab@3.2.12 build
> node scripts/build.js

Creating an optimized production build...
Failed to compile.

TS2739: Type '{ xecTxType: XecTxType.Received; satoshisSent: number; stackArray: string[]; recipients: string[]; }' is missing the following properties from type 'ParsedTx': appActions, parsedTokenEntries
    275 |                 tokenFailedParsings: [],
    276 |                 tokenStatus: 'TOKEN_STATUS_NORMAL',
  > 277 |                 parsed: {
        |                 ^^^^^^
    278 |                     xecTxType: XecTxType.Received,
    279 |                     satoshisSent: 546,
    280 |                     stackArray: [


Build cashtab-tests failed with exit code 1
bytesofman updated this revision to Diff 51596.Sun, Dec 15, 05:28

21 more tests to update / patch

Harbormaster completed remote builds in B31659: Diff 51596.Sun, Dec 15, 05:28
teamcity added a comment.Sun, Dec 15, 05:31
Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.

Tail of the build log:

Run `npm audit` for details.

> ecash-lib@1.1.0 build
> tsc && tsc -p ./tsconfig.build.json && cp -r ./src/ffi ./dist

Installing ecash-agora dependencies...
/work/modules/ecash-agora /work/modules/ecash-lib /work/modules/ecash-lib-wasm /work/modules/ecash-script /work/modules/chronik-client /work/modules/mock-chronik-client /work/modules/ecashaddrjs /work/abc-ci-builds/cashtab-tests

added 364 packages, and audited 367 packages in 2s

60 packages are looking for funding
  run `npm fund` for details

2 vulnerabilities (1 moderate, 1 high)

To address all issues, run:
  npm audit fix

Run `npm audit` for details.

> ecash-agora@0.2.0 build
> tsc && tsc -p ./tsconfig.build.json

/work/cashtab /work/modules/ecash-agora /work/modules/ecash-lib /work/modules/ecash-lib-wasm /work/modules/ecash-script /work/modules/chronik-client /work/modules/mock-chronik-client /work/modules/ecashaddrjs /work/abc-ci-builds/cashtab-tests
npm warn deprecated @humanwhocodes/config-array@0.11.14: Use @eslint/config-array instead
npm warn deprecated @humanwhocodes/object-schema@2.0.3: Use @eslint/object-schema instead
npm warn deprecated eslint@8.56.0: This version is no longer supported. Please see https://eslint.org/version-support for other options.

added 1489 packages, and audited 3335 packages in 25s

323 packages are looking for funding
  run `npm fund` for details

8 vulnerabilities (2 low, 4 moderate, 2 high)

To address issues that do not require attention, run:
  npm audit fix

To address all issues (including breaking changes), run:
  npm audit fix --force

Run `npm audit` for details.

> cashtab@3.2.12 build
> node scripts/build.js

Creating an optimized production build...
Failed to compile.

TS2739: Type '{ xecTxType: XecTxType.Received; satoshisSent: number; stackArray: string[]; recipients: string[]; }' is missing the following properties from type 'ParsedTx': appActions, parsedTokenEntries
    275 |                 tokenFailedParsings: [],
    276 |                 tokenStatus: 'TOKEN_STATUS_NORMAL',
  > 277 |                 parsed: {
        |                 ^^^^^^
    278 |                     xecTxType: XecTxType.Received,
    279 |                     satoshisSent: 546,
    280 |                     stackArray: [


Build cashtab-tests failed with exit code 1
bytesofman updated this revision to Diff 51597.Sun, Dec 15, 15:28

tests passing

Harbormaster completed remote builds in B31660: Diff 51597.Sun, Dec 15, 15:28
teamcity added a comment.Sun, Dec 15, 15:31
Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.

Tail of the build log:

Run `npm audit` for details.

> ecash-lib@1.1.0 build
> tsc && tsc -p ./tsconfig.build.json && cp -r ./src/ffi ./dist

Installing ecash-agora dependencies...
/work/modules/ecash-agora /work/modules/ecash-lib /work/modules/ecash-lib-wasm /work/modules/ecash-script /work/modules/chronik-client /work/modules/mock-chronik-client /work/modules/ecashaddrjs /work/abc-ci-builds/cashtab-tests

added 364 packages, and audited 367 packages in 2s

60 packages are looking for funding
  run `npm fund` for details

2 vulnerabilities (1 moderate, 1 high)

To address all issues, run:
  npm audit fix

Run `npm audit` for details.

> ecash-agora@0.2.0 build
> tsc && tsc -p ./tsconfig.build.json

/work/cashtab /work/modules/ecash-agora /work/modules/ecash-lib /work/modules/ecash-lib-wasm /work/modules/ecash-script /work/modules/chronik-client /work/modules/mock-chronik-client /work/modules/ecashaddrjs /work/abc-ci-builds/cashtab-tests
npm warn deprecated @humanwhocodes/config-array@0.11.14: Use @eslint/config-array instead
npm warn deprecated @humanwhocodes/object-schema@2.0.3: Use @eslint/object-schema instead
npm warn deprecated eslint@8.56.0: This version is no longer supported. Please see https://eslint.org/version-support for other options.

added 1489 packages, and audited 3335 packages in 25s

323 packages are looking for funding
  run `npm fund` for details

8 vulnerabilities (2 low, 4 moderate, 2 high)

To address issues that do not require attention, run:
  npm audit fix

To address all issues (including breaking changes), run:
  npm audit fix --force

Run `npm audit` for details.

> cashtab@3.2.12 build
> node scripts/build.js

Creating an optimized production build...
Failed to compile.

TS2739: Type '{ xecTxType: XecTxType.Received; satoshisSent: number; stackArray: string[]; recipients: string[]; }' is missing the following properties from type 'ParsedTx': appActions, parsedTokenEntries
    275 |                 tokenFailedParsings: [],
    276 |                 tokenStatus: 'TOKEN_STATUS_NORMAL',
  > 277 |                 parsed: {
        |                 ^^^^^^
    278 |                     xecTxType: XecTxType.Received,
    279 |                     satoshisSent: 546,
    280 |                     stackArray: [


Build cashtab-tests failed with exit code 1
bytesofman updated this revision to Diff 51598.Sun, Dec 15, 15:59

now tests pass

Harbormaster completed remote builds in B31661: Diff 51598.Sun, Dec 15, 16:02
teamcity added a comment.Sun, Dec 15, 16:03
Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.

Tail of the build log:

Run `npm audit` for details.

> ecash-lib@1.1.0 build
> tsc && tsc -p ./tsconfig.build.json && cp -r ./src/ffi ./dist

Installing ecash-agora dependencies...
/work/modules/ecash-agora /work/modules/ecash-lib /work/modules/ecash-lib-wasm /work/modules/ecash-script /work/modules/chronik-client /work/modules/mock-chronik-client /work/modules/ecashaddrjs /work/abc-ci-builds/cashtab-tests

added 364 packages, and audited 367 packages in 2s

60 packages are looking for funding
  run `npm fund` for details

2 vulnerabilities (1 moderate, 1 high)

To address all issues, run:
  npm audit fix

Run `npm audit` for details.

> ecash-agora@0.2.0 build
> tsc && tsc -p ./tsconfig.build.json

/work/cashtab /work/modules/ecash-agora /work/modules/ecash-lib /work/modules/ecash-lib-wasm /work/modules/ecash-script /work/modules/chronik-client /work/modules/mock-chronik-client /work/modules/ecashaddrjs /work/abc-ci-builds/cashtab-tests
npm warn deprecated @humanwhocodes/config-array@0.11.14: Use @eslint/config-array instead
npm warn deprecated @humanwhocodes/object-schema@2.0.3: Use @eslint/object-schema instead
npm warn deprecated eslint@8.56.0: This version is no longer supported. Please see https://eslint.org/version-support for other options.

added 1489 packages, and audited 3335 packages in 25s

323 packages are looking for funding
  run `npm fund` for details

8 vulnerabilities (2 low, 4 moderate, 2 high)

To address issues that do not require attention, run:
  npm audit fix

To address all issues (including breaking changes), run:
  npm audit fix --force

Run `npm audit` for details.

> cashtab@3.2.12 build
> node scripts/build.js

Creating an optimized production build...
Failed to compile.

TS2739: Type '{ xecTxType: XecTxType.Received; satoshisSent: number; stackArray: string[]; recipients: string[]; }' is missing the following properties from type 'ParsedTx': appActions, parsedTokenEntries
    275 |                 tokenFailedParsings: [],
    276 |                 tokenStatus: 'TOKEN_STATUS_NORMAL',
  > 277 |                 parsed: {
        |                 ^^^^^^
    278 |                     xecTxType: XecTxType.Received,
    279 |                     satoshisSent: 546,
    280 |                     stackArray: [


Build cashtab-tests failed with exit code 1
bytesofman updated this revision to Diff 51599.Sun, Dec 15, 17:33

ts lint, updating types, tests

Harbormaster completed remote builds in B31662: Diff 51599.Sun, Dec 15, 17:37
teamcity added a comment.Sun, Dec 15, 17:37
Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.

Tail of the build log:

> ecash-lib@1.1.0 build
> tsc && tsc -p ./tsconfig.build.json && cp -r ./src/ffi ./dist

Installing ecash-agora dependencies...
/work/modules/ecash-agora /work/modules/ecash-lib /work/modules/ecash-lib-wasm /work/modules/ecash-script /work/modules/chronik-client /work/modules/mock-chronik-client /work/modules/ecashaddrjs /work/abc-ci-builds/cashtab-tests

added 364 packages, and audited 367 packages in 2s

60 packages are looking for funding
  run `npm fund` for details

2 vulnerabilities (1 moderate, 1 high)

To address all issues, run:
  npm audit fix

Run `npm audit` for details.

> ecash-agora@0.2.0 build
> tsc && tsc -p ./tsconfig.build.json

/work/cashtab /work/modules/ecash-agora /work/modules/ecash-lib /work/modules/ecash-lib-wasm /work/modules/ecash-script /work/modules/chronik-client /work/modules/mock-chronik-client /work/modules/ecashaddrjs /work/abc-ci-builds/cashtab-tests
npm warn deprecated @humanwhocodes/config-array@0.11.14: Use @eslint/config-array instead
npm warn deprecated @humanwhocodes/object-schema@2.0.3: Use @eslint/object-schema instead
npm warn deprecated eslint@8.56.0: This version is no longer supported. Please see https://eslint.org/version-support for other options.

added 1489 packages, and audited 3335 packages in 27s

323 packages are looking for funding
  run `npm fund` for details

8 vulnerabilities (2 low, 4 moderate, 2 high)

To address issues that do not require attention, run:
  npm audit fix

To address all issues (including breaking changes), run:
  npm audit fix --force

Run `npm audit` for details.

> cashtab@3.2.12 build
> node scripts/build.js

Creating an optimized production build...

Treating warnings as errors because process.env.CI = true.
Most CI servers set it automatically.

Failed to compile.

[eslint] 
src/components/Home/Tx/index.tsx
  Line 64:5:  'AgoraTxIcon' is defined but never used  @typescript-eslint/no-unused-vars

src/token-protocols/index.ts
  Line 11:10:  'Token' is defined but never used  @typescript-eslint/no-unused-vars


Build cashtab-tests failed with exit code 1
bytesofman updated this revision to Diff 51600.Sun, Dec 15, 17:41

warning lint

Harbormaster completed remote builds in B31663: Diff 51600.Sun, Dec 15, 17:45
bytesofman updated this revision to Diff 51601.Sun, Dec 15, 18:11

comment patch

Harbormaster completed remote builds in B31664: Diff 51601.Sun, Dec 15, 18:16
bytesofman published this revision for review.Sun, Dec 15, 18:20
bytesofman edited the summary of this revision. (Show Details)
bytesofman edited the test plan for this revision. (Show Details)
bytesofman edited the test plan for this revision. (Show Details)Mon, Dec 16, 00:47
bytesofman updated this revision to Diff 51609.Mon, Dec 16, 00:49

rebase

Harbormaster completed remote builds in B31670: Diff 51609.Mon, Dec 16, 00:55
emack requested changes to this revision.EditedMon, Dec 16, 04:51
emack added a subscriber: emack.

confirm there that load times are significantly improved for wallets with Agora txs

This may be subjective but I'm not seeing a drastic improvement after updating to latest and hard refreshing twice. In some instances prod loaded the home screen and agora pages quicker than the test site, though that could also be the hosting infra playing a part. Tests were done with wallets having agora txs in tx history

cashtab/src/chronik/index.ts
866–872 ↗(On Diff #51601)

you'll need a way to tag all these logic that would be invalidated as soon as you introduce eToken->XEC trades.

901 ↗(On Diff #51601)

as above, need a way to tag these assumptions with a key word so we can just grep for it when we introduce new functions which will break these assumptions, otherwise we're bound to miss one or two in refactors.

907 ↗(On Diff #51601)

should be more explicit otherwise an unexpected value would allow it to enter this IF block.

cashtab/src/components/Home/Tx/index.tsx
847 ↗(On Diff #51601)

Why is a 0 sat agora cancel possible if 0 sat listings are not?

This revision now requires changes to proceed.Mon, Dec 16, 04:51
bytesofman updated this revision to Diff 51611.Mon, Dec 16, 05:05
bytesofman marked 4 inline comments as done.

=== p2pkh instead of !== p2sh

bytesofman added a comment.Mon, Dec 16, 05:06

This may be subjective but I'm not seeing a drastic improvement after updating to latest and hard refreshing twice. In some instances prod loaded the home screen and agora pages quicker than the test site, though that could also be the hosting infra playing a part. Tests were done with wallets having agora txs in tx history

may need to receive a tx to get the full benefit here, as there is no forced migration to the new parsed format.

cashtab/src/chronik/index.ts
866–872 ↗(On Diff #51601)

maybe. it's not really practical to try to make design assumptions based on hypothetical future transactions though.

The main guarantor here is the tests. When we need to parse new txs, we also need to make sure the old tx tests still pass.

901 ↗(On Diff #51601)

same as above -- yes, if we had some way of knowing exactly what hypotheticcal future txs might look like. Otherwise, any change here will break tests and force a fix.

907 ↗(On Diff #51601)

good point

cashtab/src/components/Home/Tx/index.tsx
847 ↗(On Diff #51601)

this is a quirk of how the tx works. There is probably a more optimal way to parse this. But, we don't really care about satosohis being sent here. An agora cancel tx only uses dust sat amounts and only involves the creator address for p2pkh.

satoshisSent is itself subjective. It depends on the tx type.

Annoyingly, some parsing will always be guesswork. So it depends in large part about the types of known txs we see and how this particular tx compares to those.

Harbormaster completed remote builds in B31672: Diff 51611.Mon, Dec 16, 05:09
emack accepted this revision.Tue, Dec 17, 08:23
This revision is now accepted and ready to land.Tue, Dec 17, 08:23
Closed by commit rABC30a23d5b0dad: [Cashtab] Parse tx history async to resolve UI lock issue on homescreen (authored by bytesofman). · Explain WhyTue, Dec 17, 14:55
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABC30a23d5b0dad: [Cashtab] Parse tx history async to resolve UI lock issue on homescreen.

Revision Contents
Changeset List

PathSize
cashtab/
src/
assets/
4 lines
chronik/
fixtures/
5091 lines
178 lines
715 lines
components/
App/
fixtures/
209 lines
Common/
4 lines
Home/
28 lines
Tx/
__tests__/
546 lines
1208 lines
6 lines
Nfts/
fixtures/
125 lines
config/
opreturn.ts
opreturn.js
2 lines
token-protocols/
__tests__/
10 lines
fixtures/
88 lines
58 lines
transactions/
fixtures/
60 lines

Diff 51611

View Options

cashtab/src/assets/agora-tx.svg

Loading...
View Options

cashtab/src/assets/tokensend.svg

Loading...
View Options

cashtab/src/chronik/fixtures/mocks.js

Loading...
View Options

cashtab/src/chronik/fixtures/vectors.js

Loading...
View Options

cashtab/src/chronik/index.ts

Loading...
View Options

cashtab/src/components/App/fixtures/mocks.ts

Loading...
View Options

cashtab/src/components/Common/CustomIcons.js

Loading...
View Options

cashtab/src/components/Home/Home.tsx

Loading...
View Options

cashtab/src/components/Home/Tx/__tests__/index.test.js

Loading...
View Options

cashtab/src/components/Home/Tx/index.tsx

Loading...
View Options

cashtab/src/components/Home/Tx/styled.ts

Loading...
View Options

cashtab/src/components/Nfts/fixtures/mocks.ts

Loading...
View Options

cashtab/src/config/opreturn.js

Loading...
View Options

cashtab/src/config/opreturn.ts

Loading...
View Options

cashtab/src/token-protocols/__tests__/index.test.ts

Loading...
View Options

cashtab/src/token-protocols/fixtures/vectors.ts

Loading...
View Options

cashtab/src/token-protocols/index.ts

Loading...
View Options

cashtab/src/transactions/fixtures/mocks.ts

Loading...