Page MenuHomePhabricator
Differential D17368

Fix race to check chaintips in p2p_headers_sync_with_minchainwork
ClosedPublic
Actions

Authored by roqqit on Tue, Dec 17, 22:35.

Details

Reviewers
Fabien
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABC607be5e6570a: Fix race to check chaintips in p2p_headers_sync_with_minchainwork
Summary

node3 is not guaranteed to have finished syncing headers by the time getchaintips is first called.

Test Plan
./test/functional/test_runner.py p2p_headers_sync_with_minchainwork.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
minchainwork-race
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 31713
Build 62922: Build Diffbuild-diff · build-clang · build-clang-tidy · build-debug · build-without-wallet
Build 62921: arc lint + arc unit

Event Timeline

roqqit created this revision.Tue, Dec 17, 22:35
Owners added a reviewer: Restricted Owners Package.Tue, Dec 17, 22:35
Herald added a reviewer: Restricted Project. · View Herald TranscriptTue, Dec 17, 22:35
roqqit requested review of this revision.Tue, Dec 17, 22:35
Harbormaster completed remote builds in B31708: Diff 51661.Tue, Dec 17, 22:51
Fabien requested changes to this revision.Wed, Dec 18, 08:35
Fabien added a subscriber: Fabien.
Fabien added inline comments.
test/functional/p2p_headers_sync_with_minchainwork.py
68–82 ↗(On Diff #51661)

why making this complicated ?

Also I generally don't like overriding the timeout, this creates flaky tests for slow machines.

This revision now requires changes to proceed.Wed, Dec 18, 08:35
roqqit updated this revision to Diff 51667.Wed, Dec 18, 16:50

feedback

Harbormaster completed remote builds in B31713: Diff 51667.Wed, Dec 18, 16:58
Fabien accepted this revision.Wed, Dec 18, 20:11
This revision is now accepted and ready to land.Wed, Dec 18, 20:11
Closed by commit rABC607be5e6570a: Fix race to check chaintips in p2p_headers_sync_with_minchainwork (authored by roqqit). · Explain WhyWed, Dec 18, 22:37
This revision was automatically updated to reflect the committed changes.
roqqit added a commit: rABC607be5e6570a: Fix race to check chaintips in p2p_headers_sync_with_minchainwork.

Revision Contents
Changeset List

PathSize
test/
functional/
31 lines

Diff 51667

View Options

test/functional/p2p_headers_sync_with_minchainwork.py

Loading...