Page MenuHomePhabricator

[Cashtab] Upgrade BigNumber.js
ClosedPublic

Authored by bytesofman on Mon, Dec 23, 00:17.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Commits
rABC2ea7234ba560: [Cashtab] Upgrade BigNumber.js
Summary

Still using "BN" from "slp-mdm" because never got around to getting rid of it. Kept thinking I could replace it totally with string methods. This is not practical for multiplication and division though.

For token quantities, we need BigNumber. And for agora quantities (nanosatoshis) we really need BigNumber.

So, we should use the latest version. And throw out the now-totally-unused slp-mdm.

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
upgrade-bignumber
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 31741
Build 62976: Build Diffcashtab-tests
Build 62975: arc lint + arc unit