Page MenuHomePhabricator

[monorepo] Use a locally installed prettier version
ClosedPublic

Authored by bytesofman on Fri, Dec 27, 21:51.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC1f2f44cf81c3: [monorepo] Use a locally installed prettier version
Summary

Currently users must globally install prettier and eslint for arc lint to work. This creates issues as in practice it is easy to globally install a different version of prettier, or for the globally installed version to vary with different versions of nodejs.

Pin the version by getting the bin from top-level node_modules.

This seems overkill for "just prettier." Plan is to extend this to eslint and also mocha / jest so that arc unit can work (only on repos that were impacted by any given diff).

Test Plan

arc lint --everything

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pin-prettier-and-eslint
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 31797
Build 63087: Build Diff
Build 63086: arc lint + arc unit