Paths

Table of Contentst

Differential D17411

[Cashtab] Move function only used on Send screen to helpers dir for Send screen
ClosedPublic
Actions

Authored by bytesofman on Fri, Dec 27, 13:36.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCee625b89b9ca: [Cashtab] Move function only used on Send screen to helpers dir for Send screen

Summary

Almost at the end of long, long effort to get rid of "wtf is this file" cashMethods.js

The last remaining function will go out after ts conversion diffs land

Test Plan

npm test

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bytesofman created this revision.Fri, Dec 27, 13:36

Herald added a reviewer: Restricted Project. · View Herald TranscriptFri, Dec 27, 13:36

Harbormaster completed remote builds in B31789: Diff 51775.Fri, Dec 27, 13:39

bytesofman published this revision for review.Fri, Dec 27, 13:41

You should move the doc as well

This revision now requires changes to proceed.Fri, Dec 27, 15:39

move doc, add return type, remove obsolete types from the doc

Harbormaster completed remote builds in B31793: Diff 51787.Fri, Dec 27, 18:16

Fabien accepted this revision.Sat, Dec 28, 13:01

This revision is now accepted and ready to land.Sat, Dec 28, 13:01

Closed by commit rABCee625b89b9ca: [Cashtab] Move function only used on Send screen to helpers dir for Send screen (authored by bytesofman). · Explain WhySat, Dec 28, 14:59

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABCee625b89b9ca: [Cashtab] Move function only used on Send screen to helpers dir for Send screen.

Revision Contents
Changeset List

Path

Size

cashtab/

package-lock.json

4 lines

package.json

2 lines

src/

components/

Send/

SendXec.tsx

2 lines

helpers/

index.ts

21 lines

	components/	Send/	helpers/
		utils/	__tests__/

	index.test.ts
	cashMethods.test.js

2 lines

utils/

__tests__/

cashMethods.test.js

cashMethods.js

16 lines

Diff 51796

View Options

cashtab/package-lock.json

View Options

cashtab/package.json

View Options

cashtab/src/components/Send/SendXec.tsx

View Options

cashtab/src/components/Send/helpers/index.test.ts

View Options

cashtab/src/components/Send/helpers/index.ts

View Options

cashtab/src/utils/tests/cashMethods.test.js

View Options

cashtab/src/utils/cashMethods.js

[Cashtab] Move function only used on Send screen to helpers dir for Send screenClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 51796

cashtab/package-lock.json

cashtab/package.json

cashtab/src/components/Send/SendXec.tsx

cashtab/src/components/Send/helpers/index.test.ts

cashtab/src/components/Send/helpers/index.ts

cashtab/src/utils/__tests__/cashMethods.test.js

cashtab/src/utils/cashMethods.js

[Cashtab] Move function only used on Send screen to helpers dir for Send screen
ClosedPublic
Actions

Revision Contents
Changeset List

cashtab/src/utils/tests/cashMethods.test.js