Page MenuHomePhabricator

[Cashtab] OrderBook show prices in XEC by default
ClosedPublic

Authored by bytesofman on Mon, Dec 30, 17:59.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC8ebe41f44a13: [Cashtab] OrderBook show prices in XEC by default
Summary

This setting is more practical for working with OrderBooks. It is easier to distinguish price differences in different offers when prices are in XEC and not fiat.

Update tests to confirm new expected behavior.

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
default-xec-spot-orderbook
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 31836
Build 63165: Build Diffcashtab-tests
Build 63164: arc lint + arc unit

Event Timeline

bytesofman edited the summary of this revision. (Show Details)
bytesofman added inline comments.
cashtab/src/components/Agora/OrderBook/index.tsx
402

clarify the name of this state variable name. we are now defaulting have the user option to displaySpotPricesInFiat as false

spotPricesXec was ambiguous

This revision is now accepted and ready to land.Mon, Dec 30, 20:21