Page MenuHomePhabricator
Differential D1846

Specialized double-SHA256 with 64 byte inputs with SSE4.1 and AVX2
ClosedPublic
Actions

Authored by deadalnix on Sep 30 2018, 16:20.

Details

Reviewers
schancel
Group Reviewers
Restricted Project
Commits
rSTAGING9c81006b6c1c: Specialized double-SHA256 with 64 byte inputs with SSE4.1 and AVX2
rABC9c81006b6c1c: Specialized double-SHA256 with 64 byte inputs with SSE4.1 and AVX2
Summary
  • Benchmark Merkle root computation
  • Refactor SHA256 code
  • Specialized double sha256 for 64 byte inputs
  • Use SHA256D64 in Merkle root computation
  • 4-way SSE4.1 implementation for double SHA256 on 64-byte inputs
  • 8-way AVX2 implementation for double SHA256 on 64-byte inputs
  • [MOVEONLY] Move unused Merkle branch code to tests
  • Enable double-SHA256-for-64-byte code on 32-bit x86
  • For AVX2 code, also check for AVX, XSAVE, and OS support

This is a backport of Core PR13191, PR13393 and PR13471

Depends on D1844 and D1845

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
sha256asm
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3454
Build 4984: Bitcoin ABC Buildbot (legacy)
Build 4983: arc lint + arc unit

Event Timeline

deadalnix created this revision.Sep 30 2018, 16:20
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 30 2018, 16:20
teamcity added a subscriber: teamcity.Sep 30 2018, 16:20

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Sep 30 2018, 16:33

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B3454: Diff 5188!Sep 30 2018, 16:33
deadalnix edited the summary of this revision. (Show Details)Sep 30 2018, 16:39
deadalnix updated this revision to Diff 5189.Sep 30 2018, 16:41

Backport bug fixes in the logic used to select the SHA256 implementation

teamcity added a comment.Sep 30 2018, 16:41

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster failed remote builds in B3455: Diff 5189!Sep 30 2018, 16:54
teamcity added a comment.Sep 30 2018, 16:54

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

deadalnix added a child revision: D1847: Improve coverage of SHA256 SelfTest code.Sep 30 2018, 17:00
deadalnix updated this revision to Diff 5200.Sep 30 2018, 20:11

Fix build

teamcity added a comment.Sep 30 2018, 20:11

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

deadalnix updated this revision to Diff 5201.Sep 30 2018, 20:13

Add release notes

teamcity added a comment.Sep 30 2018, 20:13

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B3461: Diff 5200.Sep 30 2018, 20:28
teamcity added a comment.Sep 30 2018, 20:28

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3462: Diff 5201.Sep 30 2018, 20:31
teamcity added a comment.Sep 30 2018, 20:31

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

deadalnix updated this revision to Diff 5207.Oct 1 2018, 12:22

Reformat a comment

teamcity added a comment.Oct 1 2018, 12:22

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Oct 1 2018, 12:41

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3468: Diff 5207.Oct 1 2018, 12:41
deadalnix mentioned this in T415: Add asm detection and support in cmake builds.Oct 1 2018, 16:25
deadalnix updated this revision to Diff 5224.Oct 2 2018, 11:27

rebase

teamcity added a comment.Oct 2 2018, 11:28

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Oct 2 2018, 11:45

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3478: Diff 5224.Oct 2 2018, 11:45
schancel accepted this revision.Oct 8 2018, 23:06
This revision is now accepted and ready to land.Oct 8 2018, 23:06
Closed by commit rABC9c81006b6c1c: Specialized double-SHA256 with 64 byte inputs with SSE4.1 and AVX2 (authored by Pieter Wuille <pieter.wuille@gmail.com>, committed by deadalnix). · Explain WhyOct 8 2018, 23:34
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
44 lines
src/
28 lines
3 lines
2 lines
2 lines
5 lines
bench/
8 lines
26 lines
consensus/
16 lines
148 lines
crypto/
8 lines
709 lines
458 lines
448 lines
test/
15 lines
135 lines

Diff 5188

View Options

configure.ac

Loading...
View Options

src/Makefile.am

Loading...
View Options

src/Makefile.bench.include

Loading...
View Options

src/Makefile.qt.include

Loading...
View Options

src/Makefile.qttest.include

Loading...
View Options

src/Makefile.test.include

Loading...
View Options

src/bench/crypto_hash.cpp

Loading...
View Options

src/bench/merkle_root.cpp

Loading...
View Options

src/consensus/merkle.h

Loading...
View Options

src/consensus/merkle.cpp

Loading...
View Options

src/crypto/sha256.h

Loading...
View Options

src/crypto/sha256.cpp

Loading...
View Options

src/crypto/sha256_avx2.cpp

Loading...
View Options

src/crypto/sha256_sse41.cpp

Loading...
View Options

src/test/crypto_tests.cpp

Loading...
View Options

src/test/merkle_tests.cpp

Loading...