Improve coverage of SHA256 SelfTest code
ClosedPublic
Actions

Authored by deadalnix on Sep 30 2018, 17:00.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGINGe4f75f3ddd70: Improve coverage of SHA256 SelfTest code
rABCe4f75f3ddd70: Improve coverage of SHA256 SelfTest code

Summary

This is a backport of Core's PR 13438

Depends on D1846

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

sha256test

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 3456
Build 4988: Bitcoin ABC Buildbot (legacy)
Build 4987: arc lint + arc unit

Event Timeline

deadalnix created this revision.Sep 30 2018, 17:00

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 30 2018, 17:00

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster failed remote builds in B3456: Diff 5194!Sep 30 2018, 17:14

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

deadalnix added a child revision: D1850: crypto: cleanup sha256 build.Oct 1 2018, 10:57

schancel accepted this revision.Oct 8 2018, 23:06

This revision is now accepted and ready to land.Oct 8 2018, 23:06

Scope a test case to avoid shadowing variables

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3538: Diff 5319.Oct 9 2018, 00:03

Closed by commit rABCe4f75f3ddd70: Improve coverage of SHA256 SelfTest code (authored by Pieter Wuille <pieter.wuille@gmail.com>, committed by deadalnix). · Explain WhyOct 9 2018, 00:15

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

crypto/

sha256.cpp

129 lines

Diff 5194

View Options

Improve coverage of SHA256 SelfTest codeClosedPublicActions