Differential D17497

[avalanche] Fix UB in the reward rank comparator
ClosedPublic
Actions

Authored by Fabien on Wed, Jan 8, 21:17.

Details

Reviewers

roqqit

Group Reviewers

Restricted Project

Commits

rABC7332a8874dd4: [avalanche] Fix UB in the reward rank comparator

Summary

On the first iteration of the loop there is no selected proof yet.

Test Plan

With ubsan:

ninja check-avalanche

Diff Detail

Repository

rABC Bitcoin ABC

Branch

fix_rewardrankcomparator

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 31984
Build 63460: Build Diff	lint-circular-dependencies · build-diff · build-clang-tidy · build-clang · build-debug · build-without-wallet
Build 63459: arc lint + arc unit

Event Timeline

Fabien created this revision.Wed, Jan 8, 21:17

Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Jan 8, 21:17

Fabien requested review of this revision.Wed, Jan 8, 21:17

@bot build-ubsan

teamcity awarded a token.Wed, Jan 8, 21:17

Harbormaster completed remote builds in B31984: Diff 52054.Wed, Jan 8, 21:31

roqqit accepted this revision.Wed, Jan 8, 21:45

This revision is now accepted and ready to land.Wed, Jan 8, 21:45

Closed by commit rABC7332a8874dd4: [avalanche] Fix UB in the reward rank comparator (authored by Fabien). · Explain WhyWed, Jan 8, 21:46

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC7332a8874dd4: [avalanche] Fix UB in the reward rank comparator.

Revision Contents
Changeset List

Path

Size

src/

avalanche/

peermanager.cpp

7 lines

Diff 52054

View Options

src/avalanche/peermanager.cpp

[avalanche] Fix UB in the reward rank comparatorClosedPublicActions