Page MenuHomePhabricator
Differential D17530

test: Fail if connect_nodes fails
ClosedPublic
Actions

Authored by roqqit on Wed, Jan 15, 00:07.

Details

Reviewers
Fabien
PiRK
Group Reviewers
Restricted Project
Commits
rABC4b8c65801635: test: Fail if connect_nodes fails
Summary

Pull request description:

Currently, `connect_nodes` will return silently when the connection is disconnected while connecting. This is confusing, so fix it.

Can be tested by reverting the signet test change and observing the failure when running the test.

Partial backport of core#25443

Depends on D17529

Test Plan
ninja check-functional

Diff Detail

Event Timeline

roqqit created this revision.Wed, Jan 15, 00:07
Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Jan 15, 00:07
roqqit requested review of this revision.Wed, Jan 15, 00:07
teamcity edited the summary of this revision. (Show Details)Wed, Jan 15, 00:07
roqqit added a child revision: D17531: [test] Fix intermittent timeouts in various functional tests.Wed, Jan 15, 00:11
roqqit updated this revision to Diff 52199.Wed, Jan 15, 00:13

Add back accidentally deleted comment

Harbormaster completed remote builds in B32090: Diff 52197.Wed, Jan 15, 00:24
roqqit edited the summary of this revision. (Show Details)Wed, Jan 15, 00:31
Harbormaster completed remote builds in B32092: Diff 52199.Wed, Jan 15, 00:35
Fabien accepted this revision.Wed, Jan 15, 09:18
This revision is now accepted and ready to land.Wed, Jan 15, 09:18
PiRK requested changes to this revision.Wed, Jan 15, 09:18
PiRK added a subscriber: PiRK.
PiRK added inline comments.
test/functional/test_framework/test_framework.py
683 ↗(On Diff #52199)

the diff is missing the wait_until_helper -> self.wait_until changes that are in the PR. Any reason for that?

This revision now requires changes to proceed.Wed, Jan 15, 09:18
roqqit added inline comments.Wed, Jan 15, 17:26
test/functional/test_framework/test_framework.py
683 ↗(On Diff #52199)

Good catch. Only reason is that I missed it.

roqqit updated this revision to Diff 52214.Wed, Jan 15, 17:29

Fix wait_until_helper -> self.wait_until

Harbormaster completed remote builds in B32106: Diff 52214.Wed, Jan 15, 17:43
PiRK accepted this revision.Wed, Jan 15, 19:46
This revision is now accepted and ready to land.Wed, Jan 15, 19:46
Closed by commit rABC4b8c65801635: test: Fail if connect_nodes fails (authored by laanwj <126646+laanwj@users.noreply.github.com>, committed by roqqit). · Explain WhyWed, Jan 15, 22:25
This revision was automatically updated to reflect the committed changes.
roqqit added a commit: rABC4b8c65801635: test: Fail if connect_nodes fails.

Revision Contents
Changeset List

PathSize
test/
functional/
test_framework/
17 lines

Diff 52197

View Options

test/functional/test_framework/test_framework.py

Loading...