Page MenuHomePhabricator

[explorer] Fix sorting txs by age/date
ClosedPublic

Authored by Fabien on Sat, Jan 18, 21:14.

Details

Reviewers
bytesofman
Group Reviewers
Restricted Project
Commits
rABCd160beb94e65: [explorer] Fix sorting txs by age/date
Summary

The table sorts the rendered data, i.e. the age/date string. Use the timestamp instead.
Note that due to pagination this doesn't sort over pages, but only inside the current page.

Test Plan
cargo run

Open an address page and check sorting by age and date works.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
explorer_date_sort
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 32164
Build 63818: Build Diffbuild-explorer
Build 63817: arc lint + arc unit

Event Timeline

Fabien requested review of this revision.Sat, Jan 18, 21:14

mb this issue is just from me running it locally?

sorting is broken at explorer.e.cash, but I do see the arrow highlighted on clicking to show sort:

image.png (316×192 px, 13 KB)

Running this diff, the sorting is fixed, but I do not see the up or down arrows highlight on click to indicate sort:

image.png (316×192 px, 8 KB)

The arrow highlighting still works on the "size" sort option but not Age or Date. Probably since Age and Date are now actually sorting by timestamp, so the templating is not picking up the effect.

probably still worth landing the diff to fix the behavior. I am not sure how I would fix this style issue with rust templating.

Fabien planned changes to this revision.Sat, Jan 18, 22:01

mb this issue is just from me running it locally?

sorting is broken at explorer.e.cash, but I do see the arrow highlighted on clicking to show sort:

image.png (316×192 px, 13 KB)

Running this diff, the sorting is fixed, but I do not see the up or down arrows highlight on click to indicate sort:

image.png (316×192 px, 8 KB)

The arrow highlighting still works on the "size" sort option but not Age or Date. Probably since Age and Date are now actually sorting by timestamp, so the templating is not picking up the effect.

probably still worth landing the diff to fix the behavior. I am not sure how I would fix this style issue with rust templating.

Good catch I didn't notice that. Not sure what I can do about it but I can investigate.

This revision is now accepted and ready to land.Mon, Jan 20, 08:48
This revision was automatically updated to reflect the committed changes.